BNGP-4970: LPA reference data should not store in db #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/BNGP-4970 This change means that lpa names and data are no longer stored in the db. Storing this data for each application is unnecessary and waste of storage.
jd-barnard
reviewed
Jun 27, 2024
packages/webapp/src/routes/developer/development-project-information.js
Outdated
Show resolved
Hide resolved
…n-db' of github.com:DEFRA/biodiversity-net-gain-service into feature/BNGP-4970-lpa-reference-data-should-not-store-in-db
jd-barnard
previously approved these changes
Jul 1, 2024
…d-not-store-in-db
…d-not-store-in-db
…d-not-store-in-db
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/BNGP-4970
REF_LPA_NAMESare stored in the session cache and database which is unnecessary and a waste of storage. We fix this by calling them directly instead.