BNGP-5126 Prevent resubmission of form via back button #771
Conversation
…w to ensure it is redirected first
jd-barnard
changed the title
| name: 'redirect-view', | ||
| register: (server, _options) => { | ||
| server.decorate('toolkit', 'redirectView', function (route, data) { | ||
| if (this.request.isInjected && route !== '/test') { |
There was a problem hiding this comment.
isInjected is where we inject via a test - the exception here is the /test route which is used by the redirect-view.spec.js test to assert the redirection happens. i.e. we don't want a redirect for the existing error view tests on existing routes.
| @@ -0,0 +1,8 @@ | |||
| const addRedirectViewUsed = (handler) => { | |||
There was a problem hiding this comment.
this is preferred to having to add the boolean to all routes that return an error following a form submission - i.e. it would be easy to miss.
| @@ -186,6 +187,7 @@ const redisKeys = { | |||
| SAVE_APPLICATION_SESSION_ON_SIGNOUT_OR_JOURNEY_CHANGE, | |||
| PRE_AUTHENTICATION_ROUTE, | |||
| SAVE_APPLICATION_SESSION_ON_SIGNOUT, | |||
| VIEW_DATA | |||
There was a problem hiding this comment.
Missing a comma.
| VIEW_DATA | |
| VIEW_DATA, |
| @@ -1,4 +1,6 @@ | |||
| import constants from '../../utils/constants.js' | |||
| import { getValidReferrerUrl } from '../../utils/helpers.js' | |||
There was a problem hiding this comment.
I couldn't see getValidReferrerUrl being used in this file?
| @@ -1,5 +1,6 @@ | |||
| import constants from '../../utils/constants.js' | |||
| import { validateFirstLastNameOfLandownerOrLeaseholder } from '../../utils/helpers.js' | |||
| import { getValidReferrerUrl, validateFirstLastNameOfLandownerOrLeaseholder } from '../../utils/helpers.js' | |||
There was a problem hiding this comment.
I couldn't see getValidReferrerUrl being used in this file?
| @@ -1,5 +1,6 @@ | |||
| import constants from '../../utils/constants.js' | |||
| import { validateAddress } from '../../utils/helpers.js' | |||
| import { redirectAddress, validateAddress } from '../../utils/helpers.js' | |||
There was a problem hiding this comment.
I couldn't see redirectAddress being used in this file?
# Conflicts: # packages/webapp/src/routes/credits-purchase/nationality.js # packages/webapp/src/routes/credits-purchase/upload-metric-file.js # packages/webapp/src/routes/developer/check-metric-file.js # packages/webapp/src/routes/developer/upload-consent-to-allocate-gains.js # packages/webapp/src/routes/developer/upload-metric-file.js # packages/webapp/src/routes/developer/upload-written-authorisation.js
|
|
The main changes are in
packages/webapp/src/plugins/redirect-view.js -> a plugin to redirect to the error view (post-redirect-get pattern)
packages/webapp/src/utils/redirect-view-handler.js -> a helper to add a boolean used by the above plugin (indicating that we want to return h.view following such a redirect).
Other changes are mostly where we implement the usage of the plugin when returning a view to display an error message following a form POST.