SonarQube #2

src/server/common/controller/generic-page-controller/index.js

@@ -5,6 +5,7 @@ import {
 } from 'aws-embedded-metrics'
 import { config } from '~/src/config/config.js'
 import { createLogger } from '../../helpers/logging/logger.js'
+import { NotImplementedError } from '../../helpers/not-implemented-error.js'
 
 /**
  * @import {Page} from '../../model/page/page-model.js'
@@ -95,11 +96,11 @@ export default class GenericPageController {
 
   // eslint-disable-next-line @typescript-eslint/no-unused-vars
   handleGet(_req, _h) {
-    throw new Error('Method not implemented')
+    throw new NotImplementedError()
   }
 
   // eslint-disable-next-line @typescript-eslint/no-unused-vars
   handlePost(_req, _h) {
-    throw new Error('Method not implemented')
+    throw new NotImplementedError()
   }
 }

src/server/common/controller/generic-page-controller/index.test.js

@@ -1,6 +1,7 @@
 import { config } from '~/src/config/config.js'
 import { Page } from '../../model/page/page-model.js'
 import GenericPageController from './index.js'
+import { NotImplementedError } from '../../helpers/not-implemented-error.js'
 
 class TestPage extends Page {
   reportMetrics = {
@@ -37,6 +38,12 @@ describe('#GenricPageController', () => {
     controller = new TestGenericController(page)
   })
 
+  it('should throw not implemented error', () => {
+    const defaultController = new GenericPageController(new Page())
+    expect(() => defaultController.handleGet()).toThrow(NotImplementedError)
+    expect(() => defaultController.handlePost()).toThrow(NotImplementedError)
+  })
+
   it('should output error on getHandler', () => {
     jest.spyOn(controller, 'handleGet').mockImplementation(() => {
       throw new Error('test error')