Merge pull request #83 from DEFRA/DSFAAP-608_remove-tests-section

Dsfaap 608 remove tests section
DEFRA · Dec 18, 2024 · 98824ee · 98824ee
2 parents 62fef30 + 9893f11
commit 98824ee
Show file tree

Hide file tree

Showing 8 changed files with 12 additions and 77 deletions.
diff --git a/src/server/common/model/section/tests/tests.js b/src/server/common/model/section/tests/tests.js
diff --git a/src/server/common/model/section/tests/tests.test.js b/src/server/common/model/section/tests/tests.test.js
diff --git a/src/server/task-list/controller.js b/src/server/task-list/controller.js
@@ -1,6 +1,5 @@
 import { OriginSection } from '../common/model/section/origin/origin.js'
 import { DestinationSection } from '../common/model/section/destination/destination.js'
-import { TestsSection } from '../common/model/section/tests/tests.js'
 import { LicenceSection } from '../common/model/section/licence/licence.js'
 
 const pageTitle = 'Your Bovine Tuberculosis (TB) movement licence application'
@@ -15,7 +14,6 @@ export const taskListGetController = {
   handler(req, h) {
     const origin = OriginSection.fromState(req.yar.get('origin'))
     const destination = DestinationSection.fromState(req.yar.get('destination'))
-    const tests = TestsSection.fromState()
     const licence = LicenceSection.fromState(req.yar.get('licence'))
 
     const originValidity = origin.validate()
@@ -42,14 +40,6 @@ export const taskListGetController = {
       isEnabled: isOriginValid
     })
 
-    const testsGdsTask = buildGdsTaskItem({
-      title: 'Tests',
-      initialLink: '#',
-      summaryLink: '#',
-      isValid: tests.validate().isValid,
-      isEnabled: isOriginValid
-    })
-
     const licenceGdsTask = buildGdsTaskItem({
       title: 'Receiving the licence',
       initialLink: '/receiving-the-licence/licence-enter-email-address',
@@ -58,14 +48,9 @@ export const taskListGetController = {
       isEnabled: true
     })
 
-    const gdsTasks = [
-      originGdsTask,
-      destinationGdsTask,
-      testsGdsTask,
-      licenceGdsTask
-    ]
+    const gdsTasks = [originGdsTask, destinationGdsTask, licenceGdsTask]
 
-    const allTasks = [origin, destination, tests, licence]
+    const allTasks = [origin, destination, licence]
     const incompleteTasks =
       allTasks.length -
       allTasks.filter((task) => {

diff --git a/src/server/task-list/controller.test.js b/src/server/task-list/controller.test.js
@@ -49,7 +49,6 @@ describe('#taskListController', () => {
     expect(taskTitles).toEqual([
       'Movement origin',
       'Movement destination',
-      'Tests',
       'Receiving the licence'
     ])
   })

diff --git a/user-journey-tests/page-objects/finalAnswersPage.js b/user-journey-tests/page-objects/finalAnswersPage.js
@@ -36,16 +36,12 @@ class FinalAnswersPage extends Page {
     return $$(valueIdentifier)[3]
   }
 
-  get testsValue() {
-    return $$(valueIdentifier)[4]
-  }
-
   get receivingMethodValue() {
-    return $$(valueIdentifier)[5]
+    return $$(valueIdentifier)[4]
   }
 
   get emailValue() {
-    return $$(valueIdentifier)[6]
+    return $$(valueIdentifier)[5]
   }
 
   get onOffFarmChange() {
@@ -64,10 +60,6 @@ class FinalAnswersPage extends Page {
     return $('[data-testid="destination-change-link"]')
   }
 
-  get testsChange() {
-    return $('[data-testid="tests-change-link"]')
-  }
-
   get receivingMethodChange() {
     return $('[data-testid="licence-choice-change-link"]')
   }

diff --git a/user-journey-tests/specs/finalAnswers.spec.js b/user-journey-tests/specs/finalAnswers.spec.js
@@ -52,7 +52,7 @@ describe('Check your final answers test', () => {
     await licenceAnswersPage.selectContinue()
     await taskListPage.verifyPageHeadingAndTitle()
     await taskListPage.verifyStatus({
-      position: 4,
+      position: 3,
       taskTitle: 'Receiving the licence',
       expectedStatus: 'Completed'
     })

diff --git a/user-journey-tests/specs/receiving-the-licence/licenceAnswers.spec.js b/user-journey-tests/specs/receiving-the-licence/licenceAnswers.spec.js
@@ -45,7 +45,7 @@ describe('Check your licence answers test', () => {
     await licenceAnswersPage.selectContinue()
     await taskListPage.verifyPageHeadingAndTitle()
     await taskListPage.verifyStatus({
-      position: 4,
+      position: 3,
       taskTitle: 'Receiving the licence',
       expectedStatus: 'Completed'
     })

diff --git a/user-journey-tests/specs/taskList.spec.js b/user-journey-tests/specs/taskList.spec.js
@@ -25,15 +25,14 @@ describe('Task list page test', () => {
         taskTitle: 'Movement destination',
         expectedStatus: 'Cannot start yet'
       },
-      { position: 3, taskTitle: 'Test', expectedStatus: 'Cannot start yet' },
       {
-        position: 4,
+        position: 3,
         taskTitle: 'Receiving the licence',
         expectedStatus: 'Incomplete'
       }
     ])
 
-    expect(await taskListPage.getTaskToCompleteCount()).toBe('4 out of 4')
+    expect(await taskListPage.getTaskToCompleteCount()).toBe('3 out of 3')
   })
 
   it('Should link to movement origin first question before an application has been started', async () => {
@@ -60,15 +59,14 @@ describe('Task list page test', () => {
         taskTitle: 'Movement destination',
         expectedStatus: 'Incomplete'
       },
-      { position: 3, taskTitle: 'Test', expectedStatus: 'Incomplete' },
       {
-        position: 4,
+        position: 3,
         taskTitle: 'Receiving the licence',
         expectedStatus: 'Incomplete'
       }
     ])
 
-    expect(await taskListPage.getTaskToCompleteCount()).toBe('3 out of 4')
+    expect(await taskListPage.getTaskToCompleteCount()).toBe('2 out of 3')
 
     await taskListPage.selectMovementOrigin()
     await checkAnswersPage.verifyPageHeadingAndTitle(
@@ -97,15 +95,14 @@ describe('Task list page test', () => {
         taskTitle: 'Movement destination',
         expectedStatus: 'Cannot start yet'
       },
-      { position: 3, taskTitle: 'Test', expectedStatus: 'Cannot start yet' },
       {
-        position: 4,
+        position: 3,
         taskTitle: 'Receiving the licence',
         expectedStatus: 'Completed'
       }
     ])
 
-    expect(await taskListPage.getTaskToCompleteCount()).toBe('3 out of 4')
+    expect(await taskListPage.getTaskToCompleteCount()).toBe('2 out of 3')
 
     await taskListPage.selectReceiveTheLicence()
     await licenceAnswersPage.verifyPageHeadingAndTitle()