No menu entry if weight <= 0 #274
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch allows hosting of pages without a menu entry. At the moment, all pages would create a menu entry, even those without a weight set.
knarrff
added a commit
that referenced
this pull request
Jun 9, 2024
This page should list definitions of the term "research software" together with their sources and noteable uses. At the moment, this is a proposal, and thus, only available in English. Once accepted, a German version would need to be created as well. This PR depends on the PR #274 for the page not to show up in the main manu.
fiveop
reviewed
Jun 10, 2024
| @@ -31,7 +31,7 @@ | |||
| {% assign pg = site.pages | sort: "weight" %} | |||
| {% for node in pg %} | |||
| <!-- Neglect imprint.html and index.html in either language --> | |||
| {% unless node.path contains "imprint" or node.path contains "index" %} | |||
| {% unless node.path contains "imprint" or node.path contains "index" or node.weight <= 0 %} | |||
There was a problem hiding this comment.
What is the weight with non explicitly provided? And if it is zero, couldn’t we get rid of the first two special cases? And if it isn’t, why don’t we set it explicitly to zero for imprint and index and remove the special cases?
There was a problem hiding this comment.
Good point. Will need to test this. I was so focused on "making my use-case work" and less on "how to make things nicer overall". :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows hosting of pages without a menu entry. At the moment, all pages would create a menu entry, even those without a weight set.