8 player support

[Yukitty]

Pull Request

General Description

Remake / Update of pull request #175. 🙂

Rebased to current version. Fixed a buffer overflow in an otherwise unused array hiding player 5's HUD due to data misinterpretation. There should be no remaining glitches (it's fully playable and stable at the moment), but I still haven't fully combed through the codebase again double-checking my old work.

[Yukitty]

If you're still doing input-rework-revival in a separate branch or whatever, I'm still willing to do the work to merge with it myself. I'd like to have input and player slots figured out before adding networking.

Originally posted by @Yukitty in 2019

[Yukitty]

It doesn't make sense for the Wii build to show 8 players though, right? Can the console itself even connect with more than 4 controllers at a time?

[Formedras]

It doesn't make sense for the Wii build to show 8 players though, right? Can the console itself even connect with more than 4 controllers at a time?

Yes, actually. Four Wii controllers over Bluetooth*, and four wired GameCube controllers. It's not a situation that you'll ever come up across in real use, though, so it might be worth sticking with just 4-player support on that platform.

*To my knowledge, the only controllers for the original Wii that Nintendo released that took a slot were the Wii Remote and the Wii Balance Board. The Pro Controller didn't work on the Wii, but did use a Wii controller slot on the Wii U.

[Yukitty]

I see that this is still "too big" of a lump of code changes by itself. I shouldn't have merged all of the little changes together into one big commit without context. I'm sorry.