Fix A-10C II CMSP switches not working #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Converting this to draft until we can figure out which branches have this behavior and when it changed. |
|
So it seems like ED changed the values coming from this switch, which is why it stopped working in the latest update. |
|
This is OK. Something with moving the switches down but at the moment this is the best that can be done. |
jdahlblom
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #495 - mostly. I haven't been able to get -1 to 1 working.
I'm also frankly not sure how this ever worked. Maybe the DCS luas changed recently? But these switches are definitely defined as -1 to 1 in the luas.
I've also added logging to input processing so that if input processing throws, it will be logged. We should be able to utilize this in the future and simply throw when unexpected things happen in input processors, rather than working up some weird logging stuff.