Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AV8BNA : Added two radio controls #400

Merged
merged 5 commits into from
Oct 12, 2023
Merged

AV8BNA : Added two radio controls #400

merged 5 commits into from
Oct 12, 2023

Conversation

jdahlblom
Copy link
Contributor

No description provided.

charliefoxtwo
charliefoxtwo reviewed Oct 12, 2023
View reviewed changes
Copy link
Member

@charliefoxtwo charliefoxtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this module has some calls to get_frequency elsewhere in it - we should take a look at those and consider removing those controls if they just do exactly what this one does.

Also, remember to include the json and header file

Scripts/DCS-BIOS/lib/modules/aircraft_modules/AV8BNA.lua Outdated Show resolved Hide resolved
@jdahlblom jdahlblom marked this pull request as ready for review October 12, 2023 15:22
@jdahlblom jdahlblom added this pull request to the merge queue Oct 12, 2023
Merged via the queue into DCS-Skunkworks:master with commit 3af706c Oct 12, 2023
2 checks passed
@jdahlblom jdahlblom deleted the av8-radios-added branch October 12, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliefoxtwo charliefoxtwo charliefoxtwo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdahlblom @charliefoxtwo