Move DigitalDisplay, TextDisplay to new folder #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm OK with this, but is this what we want? Is common_modules for aircraft modules or for any lua module? I figured it was just for aircraft modules. |
|
Well atm where would they go? They are common to any aircraft module right now. |
|
To me, since they're common to any aircraft module, they should be below anything that uses them. I try to avoid things having dependencies on adjacent folders or subfolders when possible. Perhaps lib/modules/ would be the best place? |
charliefoxtwo
approved these changes
Oct 6, 2023
jdahlblom
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compile worked OK.