Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot change "principal" to "reference" editions in editor #245

Closed
paregorios opened this issue Mar 15, 2017 · 12 comments
Closed

cannot change "principal" to "reference" editions in editor #245

paregorios opened this issue Mar 15, 2017 · 12 comments

Comments

@paregorios
Copy link
Member

paregorios commented Mar 15, 2017

see related issue #313

@paregorios
Copy link
Member Author

Here, incidentally, is the distinction that @rogerbagnall drew between "principal edition" and "reference edition" when confusion erupted previously. It doesn't provide an answer for my question above, but it is relevant.

@rla2118
Copy link

rla2118 commented Mar 22, 2017

I don't know if this is related to the problem that users have experienced of not being able to save reference editions. The default seems to be "principal edition." I'm drawing @Edelweiss into the conversation.

@paregorios
Copy link
Member Author

@rla2118 is the "unable to save reference editions" problem ticketed somewhere?

@rla2118
Copy link

rla2118 commented Mar 22, 2017

No, because I wondered if this ticket is related.

@paregorios
Copy link
Member Author

@rla2118 if you have (or can get) a good step-by-step description of what's happening to users when they try to do that, can you paste it in here?

@rla2118
Copy link

rla2118 commented Mar 22, 2017

Here is what Thomas Backhuys reports in submission notes for http://litpap.info/editor/publications/378# = TM 59221.

"Text according to edition P.Köln II 58 (cannot save this biblio reference as "reference edition": editor changes name to "principal edition")"

When he tries to change the biblio reference from "reference edition" to "principal edition" the system defaults to "principal edition". The XML looks like this

     <div type="bibliography" subtype="principalEdition">
        <listBibl>
           <bibl n="1" type="reference" subtype="principal">
        <!-- ignore - start, i.e. SoSOL users may not edit this -->
              <title level="s" type="short-Checklist" n="1">P.Köln 2</title>
              <author n="1">
                 <forename>Bärbel</forename>
                 <surname>Kramer</surname>
              </author>
              <pubPlace n="1">Opladen</pubPlace>
              <date>1978</date>
              <!-- ignore - stop -->
              <ptr target="http://papyri.info/biblio/9119"/>
              <biblScope n="1" unit="numbers">58</biblScope>
              <biblScope n="2" unit="volume">2</biblScope>
           </bibl>
           <bibl n="2" type="publication" subtype="principal">
        <!-- ignore - start, i.e. SoSOL users may not edit this -->
              <title level="j" type="short-BP">ZPE</title>
              <author n="1">
                 <surname>Merkelbach</surname>
                 <forename>Reinhold</forename>
              </author>
              <date>1974</date>
              <!-- ignore - stop -->
              <ptr target="http://papyri.info/biblio/50165"/>
              <biblScope n="1" unit="volume">14</biblScope>
              <biblScope n="2" unit="pp">97-113</biblScope>
           </bibl>
        </listBibl>

@paregorios
Copy link
Member Author

From what @rla2118 reports above, this sounds indeed like something that stems from an editor behavior. I'm tagging it accordingly and leaving it assigned to @Edelweiss.

@Edelweiss
Copy link

google sheet for duplicate biblio refs

@jcowey jcowey modified the milestones: May 2017, April 2017 May 4, 2017
@paregorios paregorios modified the milestones: May 2017, June 2017 Jun 1, 2017
@paregorios
Copy link
Member Author

@jcowey do you know what needs to be done here?

@paregorios paregorios assigned jcowey and unassigned Edelweiss Jul 19, 2017
@paregorios paregorios modified the milestones: Final Release, June 2017 Jul 19, 2017
@paregorios
Copy link
Member Author

Multiple users at the NYC event have experienced the same problem with the editor that @rla2118 describes above, namely: attempting to change the type of a citation from "principal" to "reference" (or similar), saving the metadata, and then discovering that the change has not been made.

@paregorios paregorios changed the title apparently duplicate "principal" and "reference" editions cannot change "principal" to "reference" editions in editor Aug 9, 2017
@jcowey jcowey removed their assignment Aug 17, 2017
@jcowey jcowey added in work and removed question labels Aug 17, 2017
@Edelweiss
Copy link

DCLP/sosol@6e663d5

@jcowey
Copy link
Contributor

jcowey commented Aug 30, 2017

Tested and works for me

@jcowey jcowey closed this as completed Aug 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants