Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

click through biblio number in principalEdition citation display #133

Open
paregorios opened this issue Apr 30, 2015 · 12 comments
Open

click through biblio number in principalEdition citation display #133

paregorios opened this issue Apr 30, 2015 · 12 comments

Comments

@paregorios
Copy link
Member

At present, the standard biblio-collection code that we're hijacking to serialize citations for bibliography in the principalEdition div of DCLP texts prints first the bibliographic ID number and then the standard-format citation. @jcowey would like to see, when we produce citations inside HTML pages for DCLP items, this id number be a link to the corresponding bibliographic record in HTML.

So, for example:

In the HTML for TM 108908, we find a reference as follows:

75990. John LUNDON, "PSI inv. 320 verso: Fragment einer Rede?," Zeitschrift fur Papyrologie und Epigraphik, 159 (2007).

We'd like the string 75990 linked to the corresponding HTML (i.e., http://server.domain.address/biblio/75990). If possible, it might also be preferable to move this number to the end of the citation, instead of keeping it at the beginning.

Note that these changes will have to be made in such a way that they only occur when we are processing a DCLP XML file for transform. Transformation of a biblio file for the purposes of displaying bibliography must be left untouched.

Relevant intervention point in the code is probably here.

@paregorios
Copy link
Member Author

@jcowey has suggested via Skype that the number be moved to the end of the citation. @rogerbagnall has observed via email that the number as presently deployed is non-sensical to most users. I wonder whether we should not only move it to the end, but gloss it. Another possibility is to suppress the output of the id number entirely, instead linking the title of the article, book, or chapter to the full biblio reference. What do others think? @rla2118 @Edelweiss @HolgerEssler @andreabernini

@paregorios paregorios assigned rla2118 and unassigned paregorios May 1, 2015
@jcowey
Copy link
Contributor

jcowey commented May 1, 2015

Author and title underlined and being the link to the full biblio record, would be my suggestion.

@rogerbagnall
Copy link

I agree with James's suggestions of linking, underlining, and number at the end.

@rla2118
Copy link

rla2118 commented May 2, 2015

I also like the idea of linking to the full biblio record, and would be
inclined to suppress the number.

On Sat, May 2, 2015 at 6:41 PM, rogerbagnall [email protected]
wrote:

I agree with James's suggestions of linking, underlining, and number at
the end.


Reply to this email directly or view it on GitHub
#133 (comment).

@HolgerEssler
Copy link

HolgerEssler commented May 3, 2015 via email

@paregorios
Copy link
Member Author

OK. There seems to be consensus around linking, but less so about the number. No need to resolve at the moment; we will have to add logic to detect the fact we're processing for DCLP display anyway (as opposed to BP), so let's get that in train first.

@paregorios paregorios modified the milestone: backlog May 15, 2015
@paregorios paregorios removed their assignment May 19, 2015
@paregorios paregorios modified the milestone: backlog Feb 12, 2016
@paregorios
Copy link
Member Author

I think we ought to try to answer #245 before we dig any further into this one, so I'm leaving it unassigned on the backlog for now.

@paregorios
Copy link
Member Author

#245 has not yet been addressed, and we are running out of time to start integration testing. As this seems a minor enhancement, recommend defer.

@paregorios
Copy link
Member Author

In my view, #245 is no longer a blocker for this task.

@wsalesky wsalesky self-assigned this Aug 31, 2017
@wsalesky
Copy link
Contributor

@paregorios
Clarification question: Links only on principalEdition? Or on all the citations, ie, partial, reference, previous editions.

@paregorios
Copy link
Member Author

paregorios commented Aug 31, 2017 via email

wsalesky added a commit to DCLP/navigator that referenced this issue Aug 31, 2017
@wsalesky
Copy link
Contributor

Branch: https://github.com/DCLP/navigator/tree/issue133
Commit: DCLP/navigator@38d6f66

Changes: Adds links around titles to take users to bibliographic record. Link follows the form already set up in the htm-teibibl.xsl:

<a href="/biblio/{t:idno[@type='pi']}/">[TITLE]</a>

Notes: This link does not work here: http://litpap.info/dclp/62416 or http://dclp.github.io/dclpxsltbox/output/dclp/63/62416.html. I assume this is a system issue not an XSLT issue as it follows the pattern specified in the original request. (Links for journals were already enabled, following the same pattern, and also do not resolve.)

@paregorios This one is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants