hostName must be dnsLabel #133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaggacao
force-pushed
the
da-correct-hostname
branch
from
ff4beb6
to
ccc9f01
Compare
blaggacao
commented
Oct 15, 2020
Comment on lines
+22
to
+25
| # TODO: Please help how to test the string for beeing a FQDN vs an IP address?!? | ||
| hostName = builtins.head (lib.splitString "." machineName); | ||
| # TODO: Please help how to set null in case of an empty list/no-domain (the default) | ||
| domain = builtins.concatStringsSep "." (builtins.drop 1 (lib.splitString "." machineName)); |
There was a problem hiding this comment.
Does anybody know the solution?
|
I don't think we want to break this. Let's leave it up to the user and the NixOS module system as it is today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #132
Please help with the TODOS, I don't know
nix(the language) very well.