faster CI, that runs on main (meaning we can enforce branches are up to date) #91
+19
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christina Sørensen <[email protected]>
Signed-off-by: Christina Sørensen <[email protected]>
Signed-off-by: Christina Sørensen <[email protected]>
Open
cafkafk
changed the title
cafkafk
changed the title
Signed-off-by: Christina Sørensen <[email protected]>
|
vm-tests seems to fail by opening too many files, making vault loop until it times out getting certs. May be because of the magic nix cache taking up some of those file descriptors, or maybe this is behavior that has been seen before? #90 mentions vault being flakey here, is that related? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds faster CI leveraging the GitHub actions cache via DetSys magic nix cache. It also improves conditions for running CI checks, making checks run on the main branch allowing us to setup branch protection rules to ensure PRs are up to date before being merge.
This will prevent situations like #87 from happening where CI checks have been added but the base branch is so old that it does not contain them yet.