Bibdk2021 2032 adv facets #1391
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YousefMohsen
requested changes
Feb 26, 2024
Comment on lines
5
to
13
| export default function Expand({ open, size = 3, src, bgColor }) { | ||
| return ( | ||
| <Icon | ||
| size={size} | ||
| bgColor="var(--blue)" | ||
| // bgColor="var(--blue)" | ||
| dataCy="expand-icon" | ||
| className={`${styles.expandicon} ${open ? styles.opened : styles.closed}`} | ||
| alt="expand" | ||
| src="expand.svg" |
There was a problem hiding this comment.
Bliver bgColor og src ikke brugt ? bgColor kunne evt. have default farve på "var(--blue)". Så der mindre chance for at det påvirker de steder hvor expand bliver brugt
Comment on lines
42
to
43
| <div className={styles.flex}> | ||
| {/*<div className={styles.countstyle}> {hitcount} </div>*/} |
There was a problem hiding this comment.
Skal kommenteret kode fjernes?
Comment on lines
46
to
47
| </Title> | ||
| <Title type="title6">Resultater</Title> |
There was a problem hiding this comment.
Det skal måske i Translate.json
Comment on lines
67
to
68
| <> | ||
| <Title type="title6">Afgræns din søgning</Title> |
There was a problem hiding this comment.
Skal det ikke i translate.json? 😬
Comment on lines
80
to
83
| // const facets = { | ||
| // facetLimit: 5, | ||
| // facets: ["specificmaterialtype", "subject"], | ||
| // }; |
| @@ -8,6 +8,8 @@ import Text from "@/components/base/text"; | |||
| import Translate from "@/components/base/translate"; | |||
| import isEmpty from "lodash/isEmpty"; | |||
| import { formattersAndComparitors } from "@/components/search/advancedSearch/useDefaultItemsForDropdownUnits"; | |||
| // import { getFacetsQuery } from "@/components/search/advancedSearch/utils"; | |||
Comment on lines
56
to
57
| /> | ||
| {/*<Text type="text1">{getFacetsQuery(selectedFacets)}</Text>*/} |
Comment on lines
29
to
30
| .accordionContainer { | ||
| /*border: 2px solid blue;*/ |
| import { useState } from "react"; | ||
| import { useRouter } from "next/router"; | ||
| import { AdvFacetsTypeEnum } from "@/lib/enums"; | ||
| import { useAdvancedSearchContext } from "@/components/search/advancedSearch/advancedSearchContext"; |
There was a problem hiding this comment.
Det kunne være super fedt hvis vi undgår at bruge useAdvancedSearchContext i useFacets. Helst den anden vej rundt 👏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.