Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add matrix gem, which is required for builds and no longer in ruby stdlib #2543

Merged
merged 1 commit into from
Apr 9, 2022

Conversation

colinxfleming
Copy link
Member

I rule and have completed some work on Case Manager that's ready for review!

Heroku builds are failing with:

/tmp/codon/tmp/buildpacks/50d5eddf222a9b7326028041d4e6509f915ccf2c/lib/language_pack/helpers/rake_runner.rb:100:in `load_rake_tasks!': Could not detect rake tasks (LanguagePack::Helpers::RakeRunner::CannotLoadRakefileError)
ensure you can run `$ bundle exec rake -P` against your app
and using the production group of your Gemfile.
rake aborted!
LoadError: cannot load such file -- matrix

turns out matrix got separated from the ruby stdlib but our heroku builds depend on it still, so re-adding it to our gemfile explicitly.

see gdelugre/origami#81 for example

This pull request makes the following changes:

  • add matrix gem to gemfile

no view changes
no issues

For reviewer:

  • Adjust the title to explain what it does for the notification email to the listserv.
  • Tag this PR:
    • feature if it contains a feature, fix, or similar. This is anything that contains a user-facing fix in some way, such as frontend changes, alterations to backend behavior, or bug fixes.
    • dependencies if it contains library upgrades or similar. This is anything that upgrades any dependency, such as a Gemfile update or npm package upgrade.
  • If it contains neither, no need to tag this PR.

@colinxfleming colinxfleming added the dependencies Pull requests that update a dependency file label Apr 9, 2022
@colinxfleming
Copy link
Member Author

godmode to get deployable

@colinxfleming colinxfleming merged commit 88feb00 into main Apr 9, 2022
@colinxfleming colinxfleming deleted the colin/matrix branch April 9, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant