Fix compilation on Ubuntu 22.04 #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with glibc 2.34 "The symbols __dn_comp, __dn_expand, __dn_skipname, __res_dnok, __res_hnok, __res_mailok, __res_mkquery, __res_nmkquery, __res_nquery, __res_nquerydomain, __res_nsearch, __res_nsend, __res_ownok, __res_query, __res_querydomain, __res_search, __res_send formerly in libresolv have been renamed and no longer have a __ prefix. They are now available in libc." https://sourceware.org/pipermail/libc-alpha/2021-August/129718.html The hex_to_string array in include/dh.h also conflicts with OpenSSL, which OpenSSL 3.0 now complains about.
progval
pushed a commit
to progval/irctest
that referenced
this pull request
Jun 25, 2023
* Update workflows to run on Ubuntu 22.04. * Add a patch to fix Bahamut on Ubuntu 22.04. Source: DALnet/bahamut#219 * Add a patch to fix Charybdis on Ubuntu 22.04.
eaescob
approved these changes
Jul 7, 2023
This was referenced Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #218 by having configure check whether the 3 resolver functions start with a
__prefix instead of having the code depend on the GLIBC version number.Also rename the
hex_to_stringarray ininclude/dh.hsince OpenSSL 3.0 started complaining that the array conflicts with an OpenSSL function.