Dev #14
Merged
Dev #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tifier classes to have two subclasses, one for each parser that we use and implemented the ProjectParserHelper to create the corresponding LeafNode and RelationshipIdentifier classes based on the ParserType
…tifier classes to have two subclasses, one for each parser that we use and implemented the ProjectParserHelper to create the corresponding LeafNode and RelationshipIdentifier classes based on the ParserType
# Conflicts: # src/main/java/parser/JDTFileVisitor.java # src/main/java/parser/ProjectParser.java # src/main/java/parser/ProjectParserHelper.java # src/test/java/parser/NodeParsingTest.java # src/test/java/parser/RelationshipIdentifierTest.java
Not 100% refactored. Without tests. Old parser.
…tifier classes to have two subclasses, one for each parser that we use and implemented the ProjectParserHelper to create the corresponding LeafNode and RelationshipIdentifier classes based on the ParserType
Fixed changing the .classpath file.
Test for PlantUML texts
Issue Fixed: - Doubling all fields, methods and relationships, when extracting a diagram twice without closing it.
Added the reduce of the graph's width, when the extracted image is bigger than 4096x4096.
…ntedArchitectureDiagrammerDaintiness into dimanyfantakis-parser
Add to build path needed.
- Added PlantUML Text extraction. - Added method descriptions to - PlantUML methods on Interfaces. - Changed PlantUML button to PlantUML Image
dimanyfantakis
approved these changes
May 19, 2023
dimanyfantakis
approved these changes
May 19, 2023
billdodis
approved these changes
May 19, 2023
|
We have to decide on this.
Here, I work on Eclipse + many others of the group.
And I would prefer not supporting all the possible editors.
On the other hand, all of you work on idea.
…On Fri, May 19, 2023 at 9:21 PM Dimitris Anyfantakis < ***@***.***> wrote:
***@***.**** approved this pull request.
I am not sure about adding the whole .idea folder to gitignore. There is
some information regarding the libraries we are using inside.
—
Reply to this email directly, view it on GitHub
<#14 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AATQLO7CC3U345K2VQ22CNLXG622FANCNFSM6AAAAAAYH66PYY>
.
You are receiving this because you authored the thread.Message ID:
<DAINTINESS-Group/ObjectOrientedArchitectureDiagrammer/pull/14/review/1434895116
@github.com>
--
Panos Vassiliadis
======================================
Professor
University of Ioannina
Dept. of Computer Science and Engineering
Ioannina, 45110, Hellas
gmail: ***@***.***
mail: ***@***.***
web: www.cs.uoi.gr/~pvassil
tel: +30-265100-8814
fax: +30-265100-8890
skype: panos_vassiliadis
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues most probably resolved: #2 #7