Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable RollForward to run on the latest .NET SDKs #909

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

nil4
Copy link
Contributor

@nil4 nil4 commented Oct 17, 2024

@nil4 nil4 requested a review from a team as a code owner October 17, 2024 14:11
Enables installing and running `CycloneDX` on runtimes/SDKs newer than those
that it targets when published. For instance, allows v4.0.0 to run with
.NET SDK 9.0 installed.

Fixes #908

Signed-off-by: nil4 <[email protected]>
@mtsfoni
Copy link
Contributor

mtsfoni commented Oct 17, 2024

I like it. Are there any potential downsides?
Breaking changes in the runtime I'd guess, but those are usually rare and very specific.

@nil4
Copy link
Contributor Author

nil4 commented Oct 17, 2024

Nothing specific that I'm aware of.

In the linked issue I gave some examples of other Microsoft-published tools (e.g. dotnet-format and docfx) having this set for a while now with no apparent downside.

One of the tools I published earlier (dotnet-xdt) also had it enabled for some years without any issues.

@nil4 nil4 mentioned this pull request Nov 17, 2024
@mtsfoni mtsfoni merged commit 7279430 into CycloneDX:master Nov 17, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants