Correct check for Windows compilation #931
Conversation
`_WIN32` is the proper check for compilation for Windows. `WIN32` is defined when `Windows.h` is included or could be defined by some projects
|
some refs: https://stackoverflow.com/a/74084728/468725 |
|
similar fix should be merged into zstd (plus all defines for |
We can still update |
|
|
You can check the decompression speed with and without the checksum, on both the library and the CLI sides. The result is very dependent on the data and the hardware system, I would expect something in the 10% range but variance is high. |
* Replace WIN32 conditions with _WIN32 or PHP_WIN32 WIN32 is defined by the SDK and not defined all the time on Windows by compilers or the environment. _WIN32 is defined as 1 when the compilation target is 32-bit ARM, 64-bit ARM, x86, or x64. Otherwise, undefined. This syncs these usages one step further. Upstream libgd has replaced WIN32 with _WIN32 via libgd/libgd@c60d9fe PHP_WIN32 is added to ext/sockets/sockets.stub.php as done in other *.stub.php files at this point. * Use PHP_WIN32 in ext/random * Use PHP_WIN32 in ext/sockets * Use _WIN32 in xxhash.h as done upstream See Cyan4973/xxHash#931 * Update end comment with PHP_WIN32
_WIN32is the proper check for compilation for Windows.WIN32is defined whenWindows.his included or could be defined by some projects