Fix REL section loading #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cuyler36
requested changes
Jan 2, 2024
vabold
force-pushed
the
rel-offset
branch
2 times, most recently
from
97995b4
to
9fd1a4f
Compare
Cuyler36
requested changes
Jun 15, 2024
Co-Authored-By: Seeky <[email protected]>
|
It might be worth it to revisit this in the future to add a toggle option on whether to include the REL headers. Additionally, it might be nice to mark the header sections 'RelocatableModuleHeader_ZZZ' or something alike. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a consequence of this, the initial memory address now refers to the start of the REL header, not the start of the first section.
The address of the BSS section can now be manually specified to match the expectation of OSLink.
Credit to Seeky for writing the initial patch for Ghidra 10.1.