fix: properly handle class/enum name in shaped array key #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes a bit the behaviour of the parser, which is now unable to properly detect missing colon for class constants or enum cases filters — for instance, in `SomeClass:SOME_CONSTANT`, the missing colon was previously detected, now it won't be. This is intentional, because this behaviour would limit the parser's ability to properly parse shaped array keys containing class/enum name. Because this was not such an important feature of the parser, there will be no replacement for it and instead will fix the issue described above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes a bit the behaviour of the parser, which is now unable to properly detect missing colon for class constants or enum cases filters — for instance, in
SomeClass:SOME_CONSTANT, the missing colon was previously detected, now it won't be.This is intentional, because this behaviour would limit the parser's ability to properly parse shaped array keys containing class/enum name.
Because this was not such an important feature of the parser, there will be no replacement for it and instead will fix the issue described above.
Fixes #337