Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding smsir backend support #85

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mojtabaakbari221b
Copy link

SMSIR is a large SMS panel in Iran.
My codes add the Backend of connection with this panel.

@CuriousLearner
Copy link
Owner

Hey @mojtabaakbari221b Thank you for your contribution!

Can you please share the API docs of that provider here?

Thanks!

@mojtabaakbari221b
Copy link
Author

Everything is similar to other package backends, only the settings are different:


PHONE_VERIFICATION = {
    . . .
    "BACKEND": "phone_verify.backends.smsir.SmsIrBackend",
    "OPTIONS": {
        "API_KEY": "fake",
        "LINENUMBER": "fake",
    },
    . . .
}

@CuriousLearner
Copy link
Owner

@mojtabaakbari221b I would like to see the associated docs on their website to know if it can the send the SMS.

Can you please provide me link to the docs on SMSIR site?

Thank you!

@CuriousLearner
Copy link
Owner

Also, the options for this BE would also need to be provided in the docs and tests.

@mojtabaakbari221b
Copy link
Author

I myself am the maintainer of sending sms package with python.
I am sure about this because I did the same tests in a personal project.

link:
https://github.com/IPeCompany/SmsPanelV2.Python

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants