CI: add cargo hack

.github/workflows/hack.yml

@@ -0,0 +1,35 @@
+name: Hack
+
+on:
+  push:
+    branches: [ "main" ]
+  pull_request:
+    branches: [ "main" ]
+  workflow_dispatch:
+
+jobs:
+  hack:
+
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Cache
+        uses: actions/cache@v4
+        with:
+          path: |
+            ~/.cargo
+            target
+          key: ${{ matrix.os }}-hack
+
+      - uses: actions/checkout@v4
+        with:
+          submodules: recursive
+
+      - name: Install dependencies
+        run: |
+          sudo apt install -y libboost-dev
+          cargo install cargo-hack --locked
+
+      - name: Hack Check
+        # TODO: remove the exclude when `cuprate-database` errors are fixed
+        run: cargo hack --workspace --exclude cuprate-database check --feature-powerset --no-dev-deps

CONTRIBUTING.md

@@ -107,7 +107,7 @@ It currently:
 - Runs [`clippy`](https://github.com/rust-lang/rust-clippy) (and fails on warnings)
 - Runs all tests
 - Builds all targets
-- Automatically adds approriate [labels](#31-labels) to your PR
+- Automatically adds appropriate [labels](#31-labels) to your PR
 
 Before pushing your code, please run the following at the root of the repository:
 
@@ -120,12 +120,13 @@ Before pushing your code, please run the following at the root of the repository
 
 After that, ensure all other CI passes by running:
 
-| Command                                                                | Does what |
-|------------------------------------------------------------------------|-----------|
-| `RUSTDOCFLAGS='-D warnings' cargo doc --workspace --all-features`      | Checks documentation is OK
-| `cargo clippy --workspace --all-features --all-targets -- -D warnings` | Checks clippy lints are satisfied
-| `cargo test --all-features --workspace`                                | Runs all tests
-| `cargo build --all-features --all-targets --workspace`                 | Builds all code
+| Command                                                                                    | Does what                                                             |
+|--------------------------------------------------------------------------------------------|-----------------------------------------------------------------------|
+| `RUSTDOCFLAGS='-D warnings' cargo doc --workspace --all-features`                          | Checks documentation is OK                                            |
+| `cargo clippy --workspace --all-features --all-targets -- -D warnings`                     | Checks clippy lints are satisfied                                     |
+| `cargo test --all-features --workspace`                                                    | Runs all tests                                                        |
+| `cargo build --all-features --all-targets --workspace`                                     | Builds all code                                                       |
+| `cargo hack --workspace --exclude cuprate-database check --feature-powerset --no-dev-deps` | Uses cargo hack to check our crates build with different features set |
 
 **Note: in order for some tests to work, you will need to place a [`monerod`](https://www.getmonero.org/downloads/) binary at the root of the repository.**
 

helper/src/atomic.rs

@@ -6,7 +6,7 @@
 use crossbeam::atomic::AtomicCell;
 
 #[allow(unused_imports)] // docs
-use std::sync::atomic::{Ordering, Ordering::Acquire, Ordering::Release};
+use core::sync::atomic::{Ordering, Ordering::Acquire, Ordering::Release};
 
 //---------------------------------------------------------------------------------------------------- Atomic Float
 /// Compile-time assertion that our floats are

helper/src/lib.rs

@@ -43,7 +43,7 @@ pub mod atomic;
 #[cfg(feature = "constants")]
 pub mod constants;
 
-#[cfg(feature = "fs")]
+#[cfg(all(feature = "fs", feature = "std"))]
 pub mod fs;
 
 pub mod network;

net/epee-encoding/src/container_as_blob.rs

@@ -1,3 +1,5 @@
+use alloc::{string::ToString, vec, vec::Vec};
+
 use bytes::{Buf, BufMut, Bytes, BytesMut};
 use ref_cast::RefCast;
 
@@ -70,7 +72,7 @@ pub trait Containerable {
 macro_rules! int_container_able {
     ($int:ty ) => {
         impl Containerable for $int {
-            const SIZE: usize = std::mem::size_of::<$int>();
+            const SIZE: usize = core::mem::size_of::<$int>();
 
             fn from_bytes(bytes: &[u8]) -> Self {
                 <$int>::from_le_bytes(bytes.try_into().unwrap())

net/epee-encoding/src/error.rs

@@ -1,3 +1,4 @@
+use alloc::string::{String, ToString};
 use core::{
     fmt::{Debug, Formatter},
     num::TryFromIntError,

net/epee-encoding/src/lib.rs

@@ -61,6 +61,7 @@
 
 extern crate alloc;
 
+use alloc::string::ToString;
 use core::{ops::Deref, str::from_utf8 as str_from_utf8};
 
 use bytes::{Buf, BufMut, Bytes, BytesMut};

net/epee-encoding/src/value.rs

@@ -1,7 +1,7 @@
 //! This module contains a [`EpeeValue`] trait and
 //! impls for some possible base epee values.
 
-use alloc::{string::String, vec::Vec};
+use alloc::{string::String, vec, vec::Vec};
 use core::fmt::Debug;
 
 use bytes::{Buf, BufMut, Bytes, BytesMut};

p2p/p2p-core/Cargo.toml

@@ -14,7 +14,7 @@ cuprate-helper = { path = "../../helper", features = ["asynch"], default-feature
 cuprate-wire = { path = "../../net/wire", features = ["tracing"] }
 cuprate-pruning = { path = "../../pruning" }
 
-tokio = { workspace = true, features = ["net", "sync", "macros", "time"]}
+tokio = { workspace = true, features = ["net", "sync", "macros", "time", "rt"]}
 tokio-util = { workspace = true, features = ["codec"] }
 tokio-stream = { workspace = true, features = ["sync"]}
 futures = { workspace = true, features = ["std"] }

storage/blockchain/Cargo.toml

@@ -15,7 +15,7 @@ default     = ["heed", "service"]
 heed        = ["cuprate-database/heed"]
 redb        = ["cuprate-database/redb"]
 redb-memory = ["cuprate-database/redb-memory"]
-service     = ["dep:crossbeam", "dep:futures", "dep:tokio", "dep:tokio-util", "dep:tower", "dep:rayon"]
+service     = ["dep:crossbeam", "dep:futures", "dep:tokio", "dep:tokio-util", "dep:tower", "dep:rayon", "dep:thread_local"]
 
 [dependencies]
 # FIXME:
@@ -38,7 +38,7 @@ futures      = { workspace = true, optional = true }
 tokio        = { workspace = true, features = ["full"], optional = true }
 tokio-util   = { workspace = true, features = ["full"], optional = true }
 tower        = { workspace = true, features = ["full"], optional = true }
-thread_local = { workspace = true }
+thread_local = { workspace = true, optional = true }
 rayon        = { workspace = true, optional = true }
 
 [dev-dependencies]