Skip tokensmanager #1771 #1795
Open
Skip tokensmanager #1771 #1795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # frontend/src/contracts.ts # frontend/src/interfaces/Contracts.ts
… are turned on
github-actions
bot
added
pr-frontend
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE UNTIL EQUIPMENT MANAGER IS IN MAIN
This branch is built on equipment manager and will require merging in main + updating migration numbers maybe.
PR Description
Implements #1771
It's a gas saving measure to skip using the TokensManager (TM) contract and interact with the main CryptoBlades (CB) contract directly if we have the phase 9.3 fees disabled on a network.
Only need to call the percentage setter in TM to toggle this, the contract will auto set the new var (29) on the CB contract based on the percentage being 0 or not.
Gas usage for fights on local:
(through TM)
win 61823
win 61557
(through CB)
win 54849
win 54849
Saves 6.8k gas, could be 0.000034205 BNB ($0.0088933), real network difference could vary (but only in a favorable direction)
Testing
Tested on local network