Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Backport several fixes for version 4 #426

Draft
wants to merge 4 commits into
base: 4_12-STABLE
Choose a base branch
from

Conversation

keithf4
Copy link
Collaborator

@keithf4 keithf4 commented Aug 16, 2024

Description

Pull in the Grafana dashboard updates in pgMonitor 5.0.0 to pgMonitor 4.11 to be able to support an upstream supported version of Grafana 10.4

Backport fix to support 3 number version of pgBackRest

Please indicate what kind of change your PR includes (multiple selections are acceptable):

  • Bugfix
  • Enhancement
  • Breaking Change
  • Documentation

PRs should be against existing issues, so please list each issue using a separate 'closes' line:

closes #425

If this PR depends on another PR or resolution of another issue, please indicate that here using a separate 'depends' line for each dependency.

depends on #

If you have an external dependency (packages, portal updates, etc), add the 'BLOCKED' tag to your PR.

Testing

None of the testing listed below is optional.

  • Installation method:
    • Binary install from source, version:
    • OS package repository, distro, and version:
    • Local package server, version:
    • Custom-built package, version:
    • Other:
  • PostgreSQL, Specify version(s):
  • docs tested with hugo version(s):

Code testing

Have you tested your changes against:

  • RedHat/CentOS
  • Ubuntu
  • SLES
  • Not applicable

If your code touches postgres_exporter, have you:

  • Tested against all versions of PostgreSQL affected
  • Ensure that exporter runs with no scrape errors
  • Not applicable

If your code touches node_exporter, have you:

  • Ensure that exporter runs with no scrape errors
  • Not applicable

If your code touches Prometheus, have you:

  • Ensured all configuration changes pass promtool check config
  • Ensured all alert rule changes pass promtool check rules
  • Prometheus runs without issue
  • Alertmanager runs without issue
  • Not applicable

If your code touches Grafana, have you:

  • Ensured Grafana runs without issue
  • Ensured relevant dashboards load without issue
  • Not applicable

Checklist:

  • I have made corresponding changes to:
    • the documentation
    • the release notes
    • the upgrade doc

@keithf4 keithf4 added the FEATURE New feature or request label Aug 16, 2024
@keithf4 keithf4 self-assigned this Aug 16, 2024
@keithf4 keithf4 changed the title fix: update grafana dashboards for supported version fix: Backport several fixes for version 4 Aug 19, 2024
@keithf4 keithf4 changed the base branch from 4_11-STABLE to 4_12-STABLE August 19, 2024 13:29
@keithf4 keithf4 requested a review from hunleyd August 19, 2024 13:30
@hunleyd hunleyd marked this pull request as draft October 16, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FEATURE New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants