Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for new alertmanager interfaces in grafana #365

Merged
merged 5 commits into from
Sep 20, 2023

Conversation

keithf4
Copy link
Collaborator

@keithf4 keithf4 commented Sep 1, 2023

Description

Add support for the new Alertmanager API interface in Grafana. Automatically provisions a new alertmanager and associates that with the Prometheus datasource.

Ran into an issue with the association not working in 9.5 when testing there, but it works in 9.2 😕
https://community.grafana.com/t/prometheus-alertmanager-association-missing-in-9-5/102703

Please indicate what kind of change your PR includes (multiple selections are acceptable):

  • Bugfix
  • Enhancement
  • Breaking Change
  • Documentation

PRs should be against existing issues, so please list each issue using a separate 'closes' line:

closes #250

If this PR depends on another PR or resolution of another issue, please indicate that here using a separate 'depends' line for each dependency.

depends on #

If you have an external dependency (packages, portal updates, etc), add the 'BLOCKED' tag to your PR.

Testing

None of the testing listed below is optional.

  • Installation method:
    • Binary install from source, version:
    • OS package repository, distro, and version: Grafana 9.2 from public repo, 9.5 from S3
    • Local package server, version:
    • Custom-built package, version:
    • Other:
  • PostgreSQL, Specify version(s):
  • docs tested with hugo version(s):

Code testing

Have you tested your changes against:

  • RedHat/CentOS
  • Ubuntu
  • SLES
  • Not applicable

If your code touches postgres_exporter, have you:

  • Tested against all versions of PostgreSQL affected
  • Ensure that exporter runs with no scrape errors
  • Not applicable

If your code touches node_exporter, have you:

  • Ensure that exporter runs with no scrape errors
  • Not applicable

If your code touches Prometheus, have you:

  • Ensured all configuration changes pass promtool check config
  • Ensured all alert rule changes pass promtool check rules
  • Prometheus runs without issue
  • Alertmanager runs without issue
  • Not applicable

If your code touches Grafana, have you:

  • Ensured Grafana runs without issue
  • Ensured relevant dashboards load without issue
  • Not applicable

Checklist:

  • I have made corresponding changes to:
    • the documentation
    • the release notes
    • the upgrade doc

@keithf4 keithf4 self-assigned this Sep 1, 2023
changelogs/fragments/250.yml Outdated Show resolved Hide resolved
@keithf4 keithf4 requested a review from hunleyd September 5, 2023 18:34
@keithf4 keithf4 added VALID Valid issue. Will be assigned and worked FEATURE New feature or request labels Sep 5, 2023
hugo/content/grafana/_index.md Outdated Show resolved Hide resolved
Co-authored-by: Douglas J Hunley <[email protected]>
@keithf4 keithf4 requested a review from hunleyd September 6, 2023 14:14
@hunleyd hunleyd merged commit 7519ea7 into CrunchyData:development Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FEATURE New feature or request VALID Valid issue. Will be assigned and worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrated Alertmanager Tab
4 participants