Applied gofmt and most of go lint's suggestions
#192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldang
commented
Oct 3, 2023
Comment on lines
-47
to
+57
| var globalDb *pgxpool.Pool = nil | ||
| var globalDb *pgxpool.Pool | ||
|
|
||
| // globalVersions holds the parsed output of postgis_full_version() | ||
| var globalVersions map[string]string = nil | ||
| var globalVersions map[string]string | ||
|
|
||
| // globalPostGISVersion is numeric, sortable postgis version (3.2.1 => 3002001) | ||
| var globalPostGISVersion int = 0 | ||
| var globalPostGISVersion int | ||
|
|
||
| // serverBounds are the coordinate reference system and extent from | ||
| // which tiles are constructed | ||
| var globalServerBounds *Bounds = nil | ||
| var globalServerBounds *Bounds |
There was a problem hiding this comment.
I was surprised by this set of go lint suggestions, but the rationale it offers is that in each case the assignment is of what would be the default value anyway.
|
I'm OK to merge this if it won't bork up any further work you've done. |
All good - all I've done since this is looking around relevant parts of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am unsure if this is helpful or not; if you'd rather I didn't do this then I'll also revert the changes in my fork. I've simply gone through
gofmt,go vet, andgo lintas a way to get myself more familiar with the code, and applied all suggestions that wouldn't be a non-trivial code edit. Some of the exported function comments are rather redundant, but I figure that having them in makes it easier to scan the rest ofgo lint's output for more important feedback.