Add support for managing VPC peering. #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngaumont
approved these changes
May 30, 2024
|
|
||
| def validate | ||
| super | ||
| check_required_args do |missing| |
There was a problem hiding this comment.
should we try to proactively prevent user to use aws_account_id if platform is not aws (same with gcp, etc)?
There was a problem hiding this comment.
Good catch. Yeah, we definitely should do that kind of check here. 👍
Add support for managing VPC peering via the `cb network` command. These changes provide the following subcommands: * `cb network create-peering` - create a new VPC peering in the target network. * `cb network delete-peering` - delete an existing VPC peering. * `cb network get-peering` - show details of an existing VPC peering. * `cb network list-peerings` - list all existing VPC peerings for the target network.
abrightwell
force-pushed
the
abrightwell/network-peering
branch
from
3e0b0ff
to
34f785d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for managing VPC peering via the
cb networkcommand.These changes provide the following subcommands:
cb network create-peering- create a new VPC peering in the target network.cb network delete-peering- delete an existing VPC peering.cb network get-peering- show details of an existing VPC peering.cb network list-peerings- list all existing VPC peerings for the target network.