Fix cb psql line wrapping issue.
#164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was reported in #158 that `cb psql` was having an issue with line wrapping when text was entered beyond the bounds of the terminal window. It turns out that this issue was related to characters in the prompt being `Colorized`. And it was these bytes of the resulting string that were causing the issue. So, we've simply removed the `Colorize` step associated with this particular output. This does not impact the coloring of the text in the prompt as that's part of the configured `PROMPT1` in the resulting `.psqlrc`. We've also take the opportunity here to update the uri fetching for the `user` role which was missed as part of #162.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was reported in #158 that
cb psqlwas having an issue with line wrapping when text was entered beyond the bounds of the terminal window. It turns out that this issue was related to characters in the prompt beingColorized. And it was these bytes of the resulting string that were causing the issue. So, we've simply removed theColorizestep associated with this particular output. This does not impact the coloring of the text in the prompt as that's part of the configuredPROMPT1in the resulting.psqlrc.We've also take the opportunity here to update the uri fetching for the
userrole which was missed as part of #162.