Handles empty firewall rule description - BR-2812

CHANGELOG.md

@@ -21,6 +21,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Fixed
 - Expired session handling not prompting for new login.
 - `cb list` completion to include `--format`.
+- `cb info` now correctly handles firewall rules with an empty description
 
 ## [3.5.1] - 2024-05-09
 ### Fixed

spec/cb/firewall_rule_spec.cr

@@ -92,15 +92,15 @@ Spectator.describe FirewallRuleList do
       action.output = IO::Memory.new
       action.network_id = network.id
 
-      expect(client).to receive(:get_firewall_rules).and_return [Factory.firewall_rule]
+      expect(client).to receive(:get_firewall_rules).and_return [Factory.firewall_rule(description: nil)]
     }
 
     it "outputs table with header" do
       action.call
 
       expected = <<-EXPECTED
         ID                           Rule         Description
-        shofthj3fzaipie44lt6a5i3de   1.2.3.0/24   Example Description
+        shofthj3fzaipie44lt6a5i3de   1.2.3.0/24
       EXPECTED
 
       expect(&.output.to_s).to look_like expected
@@ -111,7 +111,7 @@ Spectator.describe FirewallRuleList do
       action.call
 
       expected = <<-EXPECTED
-        shofthj3fzaipie44lt6a5i3de   1.2.3.0/24   Example Description
+        shofthj3fzaipie44lt6a5i3de   1.2.3.0/24
       EXPECTED
 
       expect(&.output.to_s).to look_like expected
@@ -126,7 +126,7 @@ Spectator.describe FirewallRuleList do
         "firewall_rules": [
           {
             "id": "shofthj3fzaipie44lt6a5i3de",
-            "description": "Example Description",
+            "description": null,
             "rule": "1.2.3.0/24"
           }
         ]

src/models/firewall_rule.cr

@@ -1,6 +1,6 @@
 module CB::Model
   jrecord FirewallRule,
     id : String,
-    description : String,
+    description : String?,
     rule : String
 end