EP-2518 Remove ConfirmationStep #1119
Conversation
| })) | ||
| } | ||
|
|
||
| submitOrderInternal () { |
There was a problem hiding this comment.
I'm going to dig deeper, but I'm hoping I can find a way to not have to recreate this logic here by including step-3 on this step-1 page.
There was a problem hiding this comment.
I'm sure it's possible, but there will be more branching in step-3. The tricky part will be changing step-3 to accept a new prop that lets us save the 3 forms and wait for them to finish saving before doing the submission.
There was a problem hiding this comment.
Or we could possibly do the handling of the 3 forms in an intermediary, invisible-to-the-user step?
There was a problem hiding this comment.
I guess, step-3 itself has review data in the template, so we probably don't want to use it directly; however, it might make sense to refactor the common logic out to a service and use it in both places (step-3 and branded-step-1)
Co-authored-by: Caleb Cox <[email protected]>
| @@ -1,3 +1,47 @@ | |||
| <div class="alert alert-danger" role="alert" ng-if="$ctrl.needinfoErrors || $ctrl.submissionError"> | |||
There was a problem hiding this comment.
I think we were going to put these error messages in a separate component.
https://jira.cru.org/secure/RapidBoard.jspa?rapidView=126&view=detail&selectedIssue=EP-2518&sprint=1285#