Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EP-2478] Connect Rollbar errors with DataDog RUM #1082

Merged
merged 2 commits into from
Jan 17, 2024
Merged

[EP-2478] Connect Rollbar errors with DataDog RUM #1082

merged 2 commits into from
Jan 17, 2024

Conversation

canac
Copy link
Contributor

@canac canac commented Dec 18, 2023

Extract the DataDog RUM session ID and add it to Rollbar logs.

This shouldn't be merged until after the code freeze.

https://jira.cru.org/browse/EP-2478

@canac canac added the On Staging Will be merged to the staging branch by Github Actions label Dec 18, 2023
wrandall22
wrandall22 approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@wrandall22 wrandall22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This at least works in staging: Rollbar, RUM. Hopefully the optional chaining will be enough to handle the limited session capture in prod.

@canac canac merged commit 370a629 into master Jan 17, 2024
4 checks passed
@canac canac deleted the 2478-rollbar-rum-integration branch January 17, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr-bizz dr-bizz dr-bizz approved these changes

@wrandall22 wrandall22 wrandall22 approved these changes

Assignees
No one assigned
Labels
On Staging Will be merged to the staging branch by Github Actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@canac @wrandall22 @dr-bizz