Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics fix EP upgrade #1072

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Analytics fix EP upgrade #1072

merged 2 commits into from
Nov 3, 2023

Conversation

wrandall22
Copy link
Contributor

I know you warned me, but I still missed some things in the analytics file.

@dr-bizz
Copy link
Contributor

dr-bizz commented Nov 3, 2023

I'm also seeing that on the branded Checkout we have .amount instead of .AMOUNT, I guess that needs ti change too?

@wrandall22
Copy link
Contributor Author

No, the item and the config are not the same objects. I went through branded checkout in the debugger to make sure. It basically ignores the config entirely.

@dr-bizz
Copy link
Contributor

dr-bizz commented Nov 3, 2023

I think we might also need to update this page:
src/common/services/api/designations.service.js - Line 207 & 217
Screenshot 2023-11-03 at 9 39 15 AM

@wrandall22
Copy link
Contributor Author

campaign-page is not in the config per se (e.g. it is not stored in ElasticPath) so the case is correct there. Suggested amounts are managed in AEM. I'll look closer at the amount there, but I think it doesn't need to change.

@wrandall22
Copy link
Contributor Author

Yeah, the suggested amounts piece is correct.

@wrandall22 wrandall22 added the On Staging Will be merged to the staging branch by Github Actions label Nov 3, 2023
@wrandall22 wrandall22 merged commit 0d56166 into master Nov 3, 2023
5 checks passed
@wrandall22 wrandall22 deleted the analytics-fix-ep-upgrade branch November 3, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On Staging Will be merged to the staging branch by Github Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants