Merge branch 'main' into ignore-docs-app

.changeset/config.json

@@ -15,4 +15,8 @@
   "baseBranch": "main",
   "updateInternalDependencies": "patch",
   "ignore": ["test-app", "docs-app"]
+  "bumpVersionsWithWorkspaceProtocolOnly": true,
+  "___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH": {
+    "onlyUpdatePeerDependentsWhenOutOfRange": true
+  }
 }

.changeset/twenty-tips-lie.md

@@ -0,0 +1,5 @@
+---
+'ember-headless-form': patch
+---
+
+Fixes a bug where if the submit button is clicked multiple times with async validation present the submit callback would trigger. Now if there is pending validation the submit will be cancelled to avoid extra calls.

.github/actions/pnpm/action.yml

@@ -1,22 +1,14 @@
 name: Setup node and pnpm
 description: Setup node and install dependencies using pnpm
 runs:
-  using: "composite"
+  using: 'composite'
   steps:
-    - uses: pnpm/[email protected]
-      with:
-        version: 7
-    - uses: actions/setup-node@v3
+    - uses: pnpm/[email protected]
+    - uses: actions/setup-node@v4
       with:
         cache: 'pnpm'
     - name: 'Install dependencies'
       shell: 'bash'
       run: |
         pnpm -v
-        pnpm install --fix-lockfile
-        git_diff=$(git diff)
-        if [[ "$git_diff" -eq "" ]]; then
-          echo "Success: no lockfile differences" ;
-        else
-          echo "Error: lockfile differences detected";
-        fi
+        pnpm install

.github/renovate.json5

@@ -9,6 +9,7 @@
   // bump for apps
   // update-lockfile for addons/libraries
   "rangeStrategy": "update-lockfile",
+  "prConcurrentLimit": 20,
   // From the docs:
   // https://docs.renovatebot.com/configuration-options/#packagerules
   // Important to know: Renovate will evaluate all packageRules and not stop once it gets a first match.

.github/workflows/ci.yml

@@ -22,9 +22,9 @@ jobs:
     name: Install
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: TurboRepo local server
-        uses: felixmosh/turborepo-gh-artifacts@v2
+        uses: felixmosh/turborepo-gh-artifacts@v3
         with:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
       - uses: ./.github/actions/pnpm
@@ -35,9 +35,9 @@ jobs:
     needs:
       - install_dependencies
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: TurboRepo local server
-        uses: felixmosh/turborepo-gh-artifacts@v2
+        uses: felixmosh/turborepo-gh-artifacts@v3
         with:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
       - uses: ./.github/actions/pnpm
@@ -55,13 +55,15 @@ jobs:
       fail-fast: true
       matrix:
         typescript-scenario:
-          - [email protected]
-          - [email protected]
+          - [email protected]
+          - [email protected]
+          - [email protected]
+          - [email protected]
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: TurboRepo local server
-        uses: felixmosh/turborepo-gh-artifacts@v2
+        uses: felixmosh/turborepo-gh-artifacts@v3
         with:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
       - uses: ./.github/actions/pnpm
@@ -78,9 +80,9 @@ jobs:
     needs:
       - install_dependencies
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: TurboRepo local server
-        uses: felixmosh/turborepo-gh-artifacts@v2
+        uses: felixmosh/turborepo-gh-artifacts@v3
         with:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
       - uses: ./.github/actions/pnpm
@@ -93,9 +95,9 @@ jobs:
     needs:
       - install_dependencies
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: TurboRepo local server
-        uses: felixmosh/turborepo-gh-artifacts@v2
+        uses: felixmosh/turborepo-gh-artifacts@v3
         with:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
       - uses: ./.github/actions/pnpm
@@ -123,9 +125,9 @@ jobs:
           - "'ember-release + embroider-optimized'"
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: TurboRepo local server
-        uses: felixmosh/turborepo-gh-artifacts@v2
+        uses: felixmosh/turborepo-gh-artifacts@v3
         with:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
       - uses: ./.github/actions/pnpm
@@ -146,15 +148,15 @@ jobs:
       - try_scenarios
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           persist-credentials: false
       - name: TurboRepo local server
-        uses: felixmosh/turborepo-gh-artifacts@v2
+        uses: felixmosh/turborepo-gh-artifacts@v3
         with:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
       - uses: ./.github/actions/pnpm
-      - run: pnpm build
+      - run: pnpm build:packages
       - name: Create Release Pull Request or Publish to npm
         id: changesets
         uses: changesets/action@v1
@@ -176,7 +178,7 @@ jobs:
       deployments: write
       pull-requests: write
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           persist-credentials: false
       - uses: ./.github/actions/pnpm
@@ -196,4 +198,4 @@ jobs:
             ## Preview URLs
             Env: ${{ steps.publishStep.outputs.environment }}
             Docs: ${{ steps.publishStep.outputs.url }}
-#            # api docs: ${{ steps.publishStep.outputs.url }}/api/modules.html
+#            # api docs: ${{ steps.publishStep.outputs.url }}/api/modules.html

.npmrc

@@ -0,0 +1 @@
+auto-install-peers=false

.prettierrc.js

@@ -4,4 +4,20 @@ module.exports = {
   plugins: ['prettier-plugin-ember-template-tag'],
   singleQuote: true,
   templateSingleQuote: false,
+  // this was required to make the VSCode + Prettier work correctly with <template>, see https://github.com/gitKrystan/prettier-plugin-ember-template-tag/issues/38
+  // we should roll this back once that issue has been fixed!
+  overrides: [
+    {
+      files: '*.gjs',
+      options: {
+        parser: 'ember-template-tag',
+      },
+    },
+    {
+      files: '*.gts',
+      options: {
+        parser: 'ember-template-tag',
+      },
+    },
+  ],
 };

CONTRIBUTING.md

@@ -11,21 +11,41 @@
 * `pnpm lint`
 * `pnpm lint:fix`
 
-## Building the addon
+## Developing
 
-* `cd ember-headless-form`
-* `pnpm build`
+To develop in this monorepo you can simply run:
 
-## Running tests
+ * `pnpm start`
+
+from the root directory.
+
+This will:
+
+ * Build all of the `packages/*` and watch them for changes
+ * Build the docs app and the tests app and serve them
+ * Automatically sync changes from the `packages/*` to the served apps so 
+   that they are always up to date.
+
+You can now visit:
 
-* `cd test-app`
-* `pnpm test` – Runs the test suite on the current Ember version
-* `pnpm test:watch` – Runs the test suite in "watch mode"
+ * The docs app at http://localhost:4201/
+ * The tests app at http://localhost:4202/tests
+
+If you don't need to run both apps you can save a little of your local 
+compute by running:
+
+ * `start:docs-app` and visiting http://localhost:4201/
+ * `start:test-app` and visiting http://localhost:4202/tests
+
+These commands will still build and watch the `packages/*` and sync changes
+to the running app. Don't run both `only` tasks together as this will cause
+issues - if you want to run both apps simply use `pnpm start`.
+
+## Running tests
 
-## Running the test application
+You can run the tests with the following commands:
 
-* `cd test-app`
-* `pnpm start`
-* Visit the test application at [http://localhost:4200](http://localhost:4200).
+ * `pnpm test`
+ * `pnpm test:docs`
 
 For more information on using ember-cli, visit [https://cli.emberjs.com/release/](https://cli.emberjs.com/release/).

docs-app/.ember-cli

@@ -6,10 +6,10 @@
     Setting `disableAnalytics` to true will prevent any data from being sent.
   */
   "disableAnalytics": false,
-
   /**
   Setting `isTypeScriptProject` to true will force the blueprint generators to generate TypeScript
   rather than JavaScript by default, when a TypeScript version of a given blueprint is available.
   */
-  "isTypeScriptProject": false
-}
+  "isTypeScriptProject": false,
+  "port": 4201
+}

docs-app/CHANGELOG.md

@@ -1,5 +1,45 @@
 # docs-app
 
+## 0.0.3
+
+### Patch Changes
+
+- Updated dependencies [[`6a9cc44`](https://github.com/CrowdStrike/ember-headless-form/commit/6a9cc44fc35eeb8ba034a23226ea1c2d06130969)]:
+  - [email protected]
+
+## 0.0.2
+
+### Patch Changes
+
+- Updated dependencies [[`ec33d19`](https://github.com/CrowdStrike/ember-headless-form/commit/ec33d19ee5edc81f344b12fb9a40385cedf3bb2d)]:
+  - [email protected]
+
+## 0.0.1
+
+### Patch Changes
+
+- [#144](https://github.com/CrowdStrike/ember-headless-form/pull/144) [`c62cc4a`](https://github.com/CrowdStrike/ember-headless-form/commit/c62cc4ae7cf172554debf4e0130b1300cfd2a334) Thanks [@simonihmig](https://github.com/simonihmig)! - Add documentation on updating and resetting form state
+
+- Updated dependencies [[`241ccdc`](https://github.com/CrowdStrike/ember-headless-form/commit/241ccdcedaf52d8af8b3f366b61d3055e9e38fc9), [`da9f16c`](https://github.com/CrowdStrike/ember-headless-form/commit/da9f16c5165c98c70f3f5caf0042aa162fb435bc), [`a3908fc`](https://github.com/CrowdStrike/ember-headless-form/commit/a3908fcf51dc1caa955a355c3e8e2a23d2cc341c), [`92b4338`](https://github.com/CrowdStrike/ember-headless-form/commit/92b4338811cd4dbd824f84e018fbd8eb308a5517), [`5d75011`](https://github.com/CrowdStrike/ember-headless-form/commit/5d750110000f22460207f963feed3bc7deccd473), [`fdc4ff9`](https://github.com/CrowdStrike/ember-headless-form/commit/fdc4ff9fd8a2ba00c1f2f1fe04ece8f83ffe97b3), [`7c7ff9f`](https://github.com/CrowdStrike/ember-headless-form/commit/7c7ff9f47a24eeddd9ac8f9a4c2643eb5e500582), [`544509b`](https://github.com/CrowdStrike/ember-headless-form/commit/544509b256fb171e62cc74b2cba2b2f32faa6f35), [`9b4f12b`](https://github.com/CrowdStrike/ember-headless-form/commit/9b4f12b2343402f6c11e43fd550c4e484d6ae182), [`67a5169`](https://github.com/CrowdStrike/ember-headless-form/commit/67a5169eb11552d7db9eb1f2553f59dfaad9aa65), [`6984523`](https://github.com/CrowdStrike/ember-headless-form/commit/69845235c295e05c27ab873cd0af91feebc799c2), [`ad9072b`](https://github.com/CrowdStrike/ember-headless-form/commit/ad9072bd02cb38a75a1d05efdfefb88dc827cade), [`757353d`](https://github.com/CrowdStrike/ember-headless-form/commit/757353de0015e3d10db771dfe41bd366f3a284c7), [`eb52f07`](https://github.com/CrowdStrike/ember-headless-form/commit/eb52f0756ed85b34943737248ee0dc569b5408f1)]:
+  - [email protected]
+  - [email protected]
+  - [email protected]
+
+## 0.0.1-beta.3
+
+### Patch Changes
+
+- Updated dependencies [[`da9f16c`](https://github.com/CrowdStrike/ember-headless-form/commit/da9f16c5165c98c70f3f5caf0042aa162fb435bc), [`a3908fc`](https://github.com/CrowdStrike/ember-headless-form/commit/a3908fcf51dc1caa955a355c3e8e2a23d2cc341c), [`757353d`](https://github.com/CrowdStrike/ember-headless-form/commit/757353de0015e3d10db771dfe41bd366f3a284c7)]:
+  - [email protected]
+
+## 0.0.1-beta.2
+
+### Patch Changes
+
+- Updated dependencies [[`241ccdc`](https://github.com/CrowdStrike/ember-headless-form/commit/241ccdcedaf52d8af8b3f366b61d3055e9e38fc9), [`5d75011`](https://github.com/CrowdStrike/ember-headless-form/commit/5d750110000f22460207f963feed3bc7deccd473), [`fdc4ff9`](https://github.com/CrowdStrike/ember-headless-form/commit/fdc4ff9fd8a2ba00c1f2f1fe04ece8f83ffe97b3), [`544509b`](https://github.com/CrowdStrike/ember-headless-form/commit/544509b256fb171e62cc74b2cba2b2f32faa6f35), [`67a5169`](https://github.com/CrowdStrike/ember-headless-form/commit/67a5169eb11552d7db9eb1f2553f59dfaad9aa65)]:
+  - [email protected]
+  - [email protected]
+
 ## 0.0.1-beta.1
 
 ### Patch Changes

docs-app/ember-cli-build.js

@@ -33,12 +33,13 @@ module.exports = function (defaults) {
     extraPublicTrees: [],
     staticAddonTestSupportTrees: true,
     staticAddonTrees: true,
-    staticHelpers: true,
     staticModifiers: true,
     /**
      * Docfy does not allow us to use staticComponents
      */
     staticComponents: false,
+    staticHelpers: false,
+
     splitAtRoutes: ['/', '/docs'],
     skipBabel: [
       {
@@ -75,7 +76,7 @@ module.exports = function (defaults) {
             {
               // When webpack sees an import for a CSS files
               test: /\.css$/i,
-              exclude: /node_modules/,
+              // exclude: /node_modules/,
               use: [
                 {
                   loader: 'postcss-loader',