Issue #183 Potential Heap-based Buffer Overflow

CroatiaControlLtd · Nov 23, 2021 · 3f765d3 · 3f765d3
1 parent 9aeaeee
commit 3f765d3
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 5 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -27,6 +27,9 @@ set(EXECUTABLE_OUTPUT_PATH install)
 
 set(CMAKE_CXX_STANDARD 11)
 
+#set (CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} -fno-omit-frame-pointer -fsanitize=address")
+#set (CMAKE_LINKER_FLAGS_DEBUG "${CMAKE_LINKER_FLAGS_DEBUG} -fno-omit-frame-pointer -fsanitize=address")
+
 include_directories(src/asterix)
 include_directories(src/engine)
 include_directories(src/main)

diff --git a/HISTORY b/HISTORY
@@ -249,4 +249,7 @@ Issue #178 Explicit items with more elements then in definition should be put to
 2.8.1 (python_v0.7.1)
 Issue #180 Problem decoding repetitive data item I023/120 Service Statistics
 Issue #181 Add missing Single Antenna (SA) element in Data Item I021/008 for CAT021 v2.1 
-Issue #182 convert timestamp to double, improves precision 
+Issue #182 convert timestamp to double, improves precision 
+
+2.8.2 (python_v0.7.2)
+Issue #183 Potential Heap-based Buffer Overflow
diff --git a/SECURITY.md b/SECURITY.md
@@ -2,4 +2,4 @@
 
 ## Reporting a Vulnerability
 
-Please report security issues to <email>
+Please report security issues to damir dot salantic at gmail dot com
diff --git a/asterix/version.py b/asterix/version.py
@@ -1 +1 @@
-__version__ = '0.7.1'
+__version__ = '0.7.2'
diff --git a/src/asterix/DataItemFormatExplicit.cpp b/src/asterix/DataItemFormatExplicit.cpp
@@ -68,6 +68,7 @@ bool DataItemFormatExplicit::getText(std::string &strResult, std::string &strHea
     // full length must be multiple of body length
     if (bodyLength == 0 || nFullLength % bodyLength != 0) {
         Tracer::Error("Wrong data length in Explicit. Needed=%d and there is %d bytes.", bodyLength, nFullLength);
+        return false;
     }
 
     std::string tmpStr = "";

diff --git a/src/main/version.h b/src/main/version.h
@@ -26,7 +26,7 @@
 #ifndef VERSION_H
 #define VERSION_H
 
-#define _VERSION        2.8.1
-#define _VERSION_STR   "2.8.1"
+#define _VERSION        2.8.2
+#define _VERSION_STR   "2.8.2"
 
 #endif
Original file line number	Diff line number	Diff line change
Expand Up		@@ -2,4 +2,4 @@

		## Reporting a Vulnerability

		Please report security issues to <email>
		Please report security issues to damir dot salantic at gmail dot com