Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README_Ind.md #591

Open
wants to merge 98 commits into
base: master
Choose a base branch
from
Open

Update README_Ind.md #591

wants to merge 98 commits into from

Conversation

tiotobing
Copy link

Add Description in Indonesian language, Code Ind/ID

Patrick and others added 30 commits October 11, 2018 17:07
Updated composer.json to support laravel 5.7
Fixed tests for Laravel 5.7
minor modifications
Fixed migration being published multiple times
Added more tests
Fixed setGlobalTax and setGlobalDiscount
Added Readme for merge
Add changes from Crinsane#349
Add changes from Crinsane#478
Added codecov
Added coverage.xml to .gitignore
Added secondary build for low dependency versions
Adjusted dependencies to supported php versions
Added more tests
Cleaned up __get methods
Removed EOL php versions
Added weight option from Crinsane#502
Improved Code quality and testing
bumbummen99 and others added 26 commits April 16, 2019 12:24
Update Cart.php, fix CartItem::fromAttributes call
Remove strlen from weight
Revert last change
Changed default value of $weight to 0
Added Test for CartItem.php invalid weight exception.
bumbummen99#11
Fixed copypasta in the Readme
bumbummen99#8
Added missing publish group parameter
Updated to support Laravel 6.0
Should also support Laravel 6.1
weight variable in if block
Add Description in Indonesian language, Code Ind/ID
@bumbummen99
Copy link

Good work 👍 but there are two things: first you should request a merge to bumbummen99/LaravelShoppingcart instead of Crisane's repository.
Also you will have to rename the translated Readme.md to something like Readme_hi-IN.md or Radme_gu-IN instead of changing the original.

add descriptions in Indonesian languange, Code Idn/ID
@bumbummen99
Copy link

Just noticed that you wrote indonesian, i really should not do reviews that late 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants