Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for laravel 5.8 #568

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

elhajouji5
Copy link

No description provided.

elhajouji5 and others added 2 commits June 11, 2019 19:04
Update package name so that it could be published at packagist
@bumbummen99
Copy link

I highly doubt this will be merged as you have modified the package name. Also please make sure the phpunit tests are still working.

@@ -1,5 +1,5 @@
{
"name": "gloudemans/shoppingcart",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you taking out the original author?

@lloricode
Copy link

duplicate #550

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants