Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in documentation #758

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fix typos in documentation #758

wants to merge 3 commits into from

Conversation

jsta
Copy link

@jsta jsta commented Oct 22, 2024

Fix typos in documentation

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.80%. Comparing base (d7d979e) to head (a384ece).
Report is 15 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #758      +/-   ##
===========================================
- Coverage    83.91%   81.80%   -2.11%     
===========================================
  Files           83       84       +1     
  Lines         6284     7075     +791     
===========================================
+ Hits          5273     5788     +515     
- Misses        1011     1287     +276     

see 47 files with indirect coverage changes

@ankona
Copy link
Contributor

ankona commented Oct 23, 2024

Thank you very much for the fixes! Your PR will be included in automatically generated release notes by GitHub. To make sure that is clean, could you:

  • Tweak PR title descriptiveness/format (e.g. Fix typos in documentation)
  • Include a description. In this case, it may be a copy/paste of the title

There is also a hand-updated file at doc/changelog.md that is required to pass our automated build checks. If you add the updated title to the change list under To be released at some point in the future, you'll be set to merge.

@jsta jsta changed the title typo fix Fix typos in documentation Oct 24, 2024
Copy link
Contributor

@ankona ankona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants