Merge core refactor into v1.0 feature branch #756
Merged
+20,117
−13,550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…martsim-refactor
…martsim-refactor
…martsim-refactor
Move the test suite used for SmartSim v0.X.Y to a `tests/_legacy` dir. This directory is explicitly skipped during test collection as these tests are not expected to pass as SmartSim transitions to a new user facing and core API. Additional changes to CI to make sure the feature branch continues to pass while in a chaotic development state. [ committed by @MattToast ] [ reviewed by @amandarichardsonn ]
Fixed inconsistency when adding run arguments N, nodes, or ntasks, to a RunSettings object with leading `-` characters. [ committed by @juliaputko ] [ reviewed by @amandarichardsonn ]
[ committed by @juliaputko ]
[ committed by @juliaputko ] [ reviewed by @amandarichardsonn ]
[ committed by @juliaputko ] [ reviewed by @amandarichardsonn ]
[ committed by @juliaputko ] [ reviewed by @amandarichardsonn ]
BaseJobGroup, JobGroup and ColocatedJobGroup skeletons added. [ Committed by @amandarichardsonn ] [ Reviewed by @juliaputko ]
This PR adds the Capnproto schemas and initial MessageHandler class and tests.
This PR removes `device` from the schemas, MessageHandler, and tests.
Add `Model` schema with model metadata. [ committed by @AlyssaCote ] [ approved by @ankona ]
ankona
force-pushed
the
v1.0-merge-core
branch
2 times, most recently
from
78a3a33
to
bfc36e3
Compare
ankona
force-pushed
the
v1.0-merge-core
branch
from
2ab01c4
to
0eded7d
Compare
ankona
requested review from
MattToast,
amandarichardsonn,
juliaputko and
ashao
MattToast
requested changes
Oct 23, 2024
Comment on lines
+42
to
+56
| def test_unpack_iterates_over_nested_jobs_in_expected_order(wlmutils): | ||
| launch_settings = LaunchSettings(wlmutils.get_test_launcher()) | ||
| app = Application("app_name", exe="python") | ||
| job_1 = Job(app, launch_settings) | ||
| job_2 = Job(app, launch_settings) | ||
| job_3 = Job(app, launch_settings) | ||
| job_4 = Job(app, launch_settings) | ||
| job_5 = Job(app, launch_settings) | ||
|
|
||
| assert ( | ||
| [job_1, job_2, job_3, job_4, job_5] | ||
| == list(unpack([job_1, [job_2, job_3], job_4, [job_5]])) | ||
| == list(unpack([job_1, job_2, [job_3, job_4], job_5])) | ||
| == list(unpack([job_1, [job_2, [job_3, job_4], job_5]])) | ||
| ) |
There was a problem hiding this comment.
@MattToast this test looks like it is new for the V1 API (and most of the tests in this file look like they are still valid).
TODO: Make a ticket to move valid tests from this file out of tests/_legacy
MattToast
approved these changes
Oct 24, 2024
amandarichardsonn
approved these changes
Oct 24, 2024
ankona
changed the title
ankona
force-pushed
the
v1.0-merge-core
branch
from
87319c5
to
629baa5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combine the
core-refactorfeature branch withmli-featureinv1.0branch