Ensemble.files refactor #746
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## smartsim-refactor #746 +/- ##
=====================================================
+ Coverage 40.45% 47.79% +7.33%
=====================================================
Files 110 109 -1
Lines 7326 6576 -750
=====================================================
+ Hits 2964 3143 +179
+ Misses 4362 3433 -929
|
|
Question for @juliaputko ! In application.py you placed the TODO about 2 months ago in the remove dead attrs in application PR, is this safe to remove now? |
juliaputko
reviewed
Oct 17, 2024
| :param tag: Tag to use for find and replacement | ||
| """ | ||
| self.operations.append( | ||
| EnsembleConfigureOperation(src, file_parameters, dest, tag) |
There was a problem hiding this comment.
can we change the order of these so that it matches the configure method?
There was a problem hiding this comment.
also I dont know if file_parameters is the best name for what is going in? This is a mapping of the items that need to be found and replaced right?
| @@ -424,8 +431,8 @@ def build_jobs(self, settings: LaunchSettings) -> tuple[Job, ...]: | |||
| :raises TypeError: if the ids argument is not type LaunchSettings | |||
| :raises ValueError: if the LaunchSettings provided are empty | |||
| """ | |||
| if not isinstance(settings, LaunchSettings): | |||
| raise TypeError("ids argument was not of type LaunchSettings") | |||
| # if not isinstance(settings, LaunchSettings): | |||
There was a problem hiding this comment.
remove commented lines?
|
|
||
| pytestmark = pytest.mark.group_a | ||
|
|
||
| # TODO missing test for _filter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attaching files to an Application and Ensemble has been refactored.
There is now two operations files, an operations.py file that holds the tools to attach files to an Application and an ensemble_operations.py file that holds the tools to attach files to an Ensemble. These two operation files are covered in individual test files: test_operations.py and test_ensemble_operations.py.
Additionally, building the file operation commands in the Generator has been refactored to support the removal of EntityFiles and replacement of the operations.FileSysOpSet. Tests for generator.py have been updated in test_generator.py.
Additionally, the function Ensemble._create_applications has been reworked to support the new Ensemble.files type.
Files to investigate:
smartsim/generation/operations/ensemble_operations.py
smartsim/generation/operations/operations.py
smartsim/generation/operations/utils/helpers.py
smartsim/builders/ensemble.py
smartsim/entity/application.py