Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runtime value checking for LaunchSettings and BatchSettings #740

Open
wants to merge 4 commits into
base: smartsim-refactor
Choose a base branch
from

PR review comments addressed

e9d6ed8
Select commit
Loading
Failed to load commit list.
Open

Runtime value checking for LaunchSettings and BatchSettings #740

PR review comments addressed
e9d6ed8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Oct 23, 2024 in 0s

20.00% of diff hit (target 0.00%)

View this Pull Request on Codecov

20.00% of diff hit (target 0.00%)

Annotations

Check warning on line 122 in smartsim/settings/batch_settings.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

smartsim/settings/batch_settings.py#L121-L122 

Added lines #L121 - L122 were not covered by tests

Check warning on line 129 in smartsim/settings/batch_settings.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

smartsim/settings/batch_settings.py#L129 

Added line #L129 was not covered by tests

Check warning on line 156 in smartsim/settings/batch_settings.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

smartsim/settings/batch_settings.py#L156 

Added line #L156 was not covered by tests

Check warning on line 163 in smartsim/settings/batch_settings.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

smartsim/settings/batch_settings.py#L163 

Added line #L163 was not covered by tests

Check warning on line 131 in smartsim/settings/launch_settings.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

smartsim/settings/launch_settings.py#L131 

Added line #L131 was not covered by tests

Check warning on line 138 in smartsim/settings/launch_settings.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

smartsim/settings/launch_settings.py#L138 

Added line #L138 was not covered by tests

Check warning on line 187 in smartsim/settings/launch_settings.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

smartsim/settings/launch_settings.py#L187 

Added line #L187 was not covered by tests
View more details on Codecov