Skip to content

Commit

Permalink
post-merge cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
ankona committed Oct 16, 2024
1 parent c433db9 commit 5c65cc3
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 11 deletions.
7 changes: 2 additions & 5 deletions smartsim/_core/_cli/build.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@
display_post_install_logs,
install_dragon,
)
from smartsim._core._cli.utils import SMART_LOGGER_FORMAT, color_bool, pip
from smartsim._core._cli.utils import SMART_LOGGER_FORMAT
from smartsim._core._install import builder
from smartsim._core._install.buildenv import BuildEnv, DbEngine, Version_, Versioner
Expand Down Expand Up @@ -216,8 +215,7 @@ def _format_incompatible_python_env_message(
conflict_str = fmt_list("Conflicting", conflicting)
sep = "\n" if missing_str and conflict_str else ""

return textwrap.dedent(
f"""\
return textwrap.dedent(f"""\
Python Package Warning:
Requested packages are missing or have a version mismatch with
Expand All @@ -227,8 +225,7 @@ def _format_incompatible_python_env_message(
Consider uninstalling any conflicting packages and rerunning
`smart build` if you encounter issues.
"""
)
""")


def _configure_keydb_build(versions: Versioner) -> None:
Expand Down
4 changes: 0 additions & 4 deletions smartsim/_core/_install/builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,8 @@
import stat
import subprocess
import typing as t
# import zipfile
# from abc import ABC, abstractmethod
# from dataclasses import dataclass
from pathlib import Path
from subprocess import SubprocessError
from urllib.request import build_opener, install_opener, urlretrieve

from smartsim._core._install.utils import retrieve
from smartsim._core.utils import expand_exe_path
Expand Down
2 changes: 0 additions & 2 deletions tests/test_dragon_installer.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,6 @@
retrieve_asset,
retrieve_asset_info,
)


from smartsim.error.errors import SmartSimCLIActionCancelled

# The tests in this file belong to the group_a group
Expand Down

0 comments on commit 5c65cc3

Please sign in to comment.