CRAYSAT-1750: Upgrade dependencies to allow newer PyYAML #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade dependencies to allow PyYAML 6.0.1. This version of PyYAML fixes a build problem which occurs when building PyYAML in Alpine Linux containers. Also remove PyYAML from the top-level dependencies of this package because it is actually not a direct dependency, but rather introduced through the dependencies on cfs-config-util and shasta-install-utility-common. Test Description: Unit tests pass. Will test the build from this branch on mug by running it with the `activate` argument, which is the only argument that `prodmgr` uses with this container moving forward and is the argument for which code was most impacted.
haasken-hpe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
Upgrade dependencies to allow PyYAML 6.0.1. This version of PyYAML fixes a build problem which occurs when building PyYAML in Alpine Linux containers.
Also remove PyYAML from the top-level dependencies of this package because it is actually not a direct dependency, but rather introduced through the dependencies on cfs-config-util and
shasta-install-utility-common.
Issues and Related PRs
List and characterize relationship to Jira/Github issues and other pull requests. Be sure to list dependencies.
Testing
Tested on:
Test description:
Unit tests pass. Will test the build from this branch on mug by running it with the
activateargument, which is the only argument thatprodmgruses with this container moving forward and is the argument for which code was most impacted.Test results here: https://gist.github.com/haasken-hpe/7b498724ab722042107b23ee88a54f23
Risks and Mitigations
Low risk. This is deprecated functionality, and it's just upgrading dependencies.
Pull Request Checklist