Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-463 Adapt comment nodes to use GraphFrame #464

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

GH-463 Adapt comment nodes to use GraphFrame #464

wants to merge 3 commits into from

Conversation

Naros
Copy link
Member

@Naros Naros commented Jun 30, 2024 •
edited
Loading

Fixes #463

  • Test that this remains backward compatible with Orchestrator 2.0.x builds
  • Consider frame state stored at graph level, not comment node level
  • Allow new GraphFrame to support icons
  • Apply correct corner radius and frame border color to GraphFrame
  • Fix font size between two implementations
  • Add toggle to hide titlebar or render it using the After style.

Before
image

After
image

After Adding Styling Support
image

@Naros Naros added the cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 label Jun 30, 2024
@Naros Naros added this to the 2.2 milestone Jul 21, 2024
@Naros Naros added the cherrypick:2.1 Requires cherry-pick to Orchestrator 2.1 label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 cherrypick:2.1 Requires cherry-pick to Orchestrator 2.1
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

Implement GraphFrame variant for comment nodes
1 participant
@Naros