Improve error_log & error pass-back; Add getTicket(); Silence verbose logging; Link to repo #42
Conversation
Helps as the class gets added to code-bases, easier to track it
lsthompson
changed the title
lsthompson
changed the title
pve2_api.class.php
Outdated
| error_log("Error - Invalid HTTP Response.\n" . var_export($split_headers, true)); | ||
| throw new PVE2_Exception("PVE2 API: Error - Invalid HTTP Response.\n" . var_export($split_headers, true)); | ||
| return false; |
There was a problem hiding this comment.
Throw/return paradox again.
There was a problem hiding this comment.
Not sure if you want everything reverted to error_log. Excepting is helpful as we can expect a proper reply in integrated apps, and relay the error specifics to the end user. So I'm hesitant to revert everything?
There was a problem hiding this comment.
All I meant was that once you throw, the return never gets called.
pve2_api.class.php
Outdated
| error_log("\$action_response_array['data'] is empty. Returning false.\n" . | ||
| throw new PVE2_Exception("PVE2 API: \$action_response_array['data'] is empty. Returning false.\n" . | ||
| var_export($action_response_array['data'], true)); | ||
| return false; |
There was a problem hiding this comment.
Throw/return paradox again.
Thanks for the review @danhunsaker - how's the updated pull looking now? Appreciate your pointers on all fronts. I'd like to switch back the reverted-to-error-log section? I'm a fan of passing back the specifics if it's doable. |
Helps as the class gets added to code-bases, easier to track it. You weren't wrong about not working with it!
Investigate @danhunsaker concept of PSR-3 handling mentioned in Issue #19 back in 2015.
https://www.php-fig.org/psr/psr-3/