Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated PHP SDK for cPanel API Tokens #16

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

dustin-s
Copy link

@dustin-s dustin-s commented Apr 5, 2019

In addition to the addition of API Tokens, I updated all tests and code to run on PHP 7.3 and phpunit 8.0.

This change was rather extensive as the test files were
last setup to run on PHP 5.3 and haven't been updated since.

They are now updated to run on PHP 7.3 and PHPUnit 8.
phpunit.bootstrap.php includes an abstraction class for TestCase
This commit updates that to include inline documentation.
This includes the new versions and the incantation for running
the phpunit tests via composer phpunit.
@@ -2,7 +2,7 @@
/**
* Example usage of iterating over a response (Cpanel_Query_Object)
*
* Copyright (c) 2011, cPanel, Inc.
* Copyright (c) 2011, cPanel, L.L.C.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn’t this say 2019?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants