-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated PHP SDK for cPanel API Tokens #16
Draft
dustin-s
wants to merge
8
commits into
CpanelInc:master
Choose a base branch
from
dustin-s:add-cpanel-api-token-info
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change was rather extensive as the test files were last setup to run on PHP 5.3 and haven't been updated since. They are now updated to run on PHP 7.3 and PHPUnit 8.
phpunit.bootstrap.php includes an abstraction class for TestCase This commit updates that to include inline documentation.
This includes the new versions and the incantation for running the phpunit tests via composer phpunit.
FGasper
reviewed
Apr 9, 2019
@@ -2,7 +2,7 @@ | |||
/** | |||
* Example usage of iterating over a response (Cpanel_Query_Object) | |||
* | |||
* Copyright (c) 2011, cPanel, Inc. | |||
* Copyright (c) 2011, cPanel, L.L.C. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn’t this say 2019?
Procorners
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the addition of API Tokens, I updated all tests and code to run on PHP 7.3 and phpunit 8.0.