-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#132 Possibilité de watch les centres à 0 créneaux afin d'être notifié lors de nouveaux créneaux dispos #134
Draft
fcamblor
wants to merge
27
commits into
dev
Choose a base branch
from
push-notifs
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a first implementation for center appointment subscriptions
…cations grants to the service worker when they are changing
…leIterator weren't found : Cannot find name 'AsyncIterableIterator'. Do you need to change your target library? Try changing the compiler option to 'es2018' or later.
…eworker (as we're sure to migrate DB in app before sw)
…ns once enabled. click 5 times on 'vite ma dose' footer to enable/disable this debug mode
…st + a 'fetch' listener in service worker
…service worker, instead of app, following this example from google : https://github.com/GoogleChromeLabs/so-pwa/pull/11/files
…ed service worker
… seems to work far better while the app is in the background
… as when a push notification is triggered, those variables are undefined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #132
Ça donne ça :
J'ai fait en sorte de rendre "PWA compatible" le site (c'est une condition sine qua none pour que les synchronizations périodiques fonctionnent)
Encore en DRAFT car les synchronisations périodiques ne fonctionnent pas correctement pour le moment quand l'appli est en background.
Il faut que je comprenne ce que la PWA Twitter fait pour réussir à générer de belles notifications (cf ce fichier)
Un exemple de la PR est visible ici : https://dev.vitemado.se/push-notifs/
Pour simplifier les tests, vous pouvez passer en "debug mode" en cliquant 5 fois sur le texte "VMD" en bas de page : une fois ce mode debug activé, tous les centres sur lesquels un "watch" a été positionné se mettront à avoir un nombre de créneaux random :