Timed Assessment: Timer starts only when user click "Start" while initiating Attempt #7548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bivanalhar
force-pushed
the
bivan/timed-assessment-fix
branch
8 times, most recently
from
6c79d3b
to
181cb3b
Compare
cysjonathan
requested changes
Sep 12, 2024
Comment on lines
76
to
95
| submission.workflowState === 'attempting' && | ||
| (submission.timerStartedAt ? ( | ||
| <TimeLimitBanner submissionTimeLimitAt={submissionTimeLimitAt} /> | ||
| ) | ||
| ) : ( | ||
| <Banner | ||
| className="bg-red-700 text-white border-only-b-fuchsia-200 fixed top-0 right-0" | ||
| icon={<HourglassTop />} | ||
| > | ||
| <FormattedMessage | ||
| {...translations.remainingTime} | ||
| values={{ | ||
| timeLimit: ( | ||
| <RemainingTimeTranslations | ||
| remainingTime={assessment.timeLimit * 60 * 1000} | ||
| /> | ||
| ), | ||
| }} | ||
| /> | ||
| </Banner> | ||
| )) |
There was a problem hiding this comment.
TimeLimitBanner already has some logic inside it, shouldn't you also include the additional .timerStartedAt check inside TimeLimitBanner, instead of bringing the logic out here in the SubmissionEditIndex page?
There was a problem hiding this comment.
done.. at first I don't really keen to couple the logic of not-yet-starting timer with when the timer already started. But I found a way to elegantly implement this component so that it includes both cases while keeping the code clean inside
bivanalhar
force-pushed
the
bivan/timed-assessment-fix
branch
from
181cb3b
to
0e7b329
Compare
- timer starts only after student click "Start" when start attempting the exam
- if user attempts to change the time limit, we impose warning - that it will create inconsistencies for submissions in progress
- if submission already has timer started at, we won't allow to re-configure it - add test cases regarding this API - refactor the TimeLimitBanner to accommodate when timer not started yet
bivanalhar
force-pushed
the
bivan/timed-assessment-fix
branch
from
0e7b329
to
b9fceae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.