This repository has been archived by the owner on Apr 20, 2024. It is now read-only.
Web/feature/user overview v2 #164
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamseye
temporarily deployed
to
web-frontend-web-feature-user-overview-v2
* master: Translation updates (#170) Fixed some miswording in the handbook (#168) Removed a redundant word (#166) Web/chore/profile i18n keys (#138) # Conflicts: # components/UserOverview/UserOverview.test.tsx # features/profile/view/Overview.tsx # features/profile/view/leaveReference/LeaveReferencePage.tsx
iamseye
temporarily deployed
to
web-frontend-web-feature-user-overview-v2
iamseye
temporarily deployed
to
web-frontend-web-feature-user-overview-v2
lucaslcode
suggested changes
Jul 28, 2022
| @@ -52,12 +52,17 @@ const useStyles = makeStyles((theme) => ({ | |||
| flexDirection: "column", | |||
| justifyContent: "center", | |||
| alignItems: "stretch", | |||
| padding: theme.spacing(0.5), | |||
| padding: "0px", | |||
There was a problem hiding this comment.
Suggested change
| padding: "0px", | |
| padding: 0, |
| }, | ||
| "& > button": { | ||
| fontWeight: "bold", | ||
| padding: theme.spacing(1.6), |
There was a problem hiding this comment.
Why 1.6? If it's to pixel-match figma I'd probably leave it as 1.5 for consistency (we tend to try to have all uses of spacing in 0.5 increments)
| </Typography> | ||
| <Typography variant="body1" className={classes.intro}> | ||
| {user.city} | ||
| <Typography variant="h1" className={classes.intro} align={"left"}> |
There was a problem hiding this comment.
Suggested change
| <Typography variant="h1" className={classes.intro} align={"left"}> | |
| <Typography variant="h1" className={classes.intro} align="left"> |
| </Typography> | ||
| <Typography | ||
| color={"textSecondary"} |
There was a problem hiding this comment.
Suggested change
| color={"textSecondary"} | |
| color="textSecondary" |
| {actions && ( | ||
| <CardActions className={classes.cardActions}>{actions}</CardActions> | ||
| )} | ||
| <Typography color={"primary"} variant="body1" className={classes.intro}> |
There was a problem hiding this comment.
Suggested change
| <Typography color={"primary"} variant="body1" className={classes.intro}> | |
| <Typography color="primary" variant="body1" className={classes.intro}> |
| @@ -1,10 +1,10 @@ | |||
| import Alert from "components/Alert"; | |||
| import Button from "components/Button"; | |||
| import UserOverview from "components/UserOverview/UserOverview"; | |||
There was a problem hiding this comment.
Suggested change
| import UserOverview from "components/UserOverview/UserOverview"; | |
| import UserOverview from "components/UserOverview"; |
Since you added the index file
| @@ -1,10 +1,10 @@ | |||
| import Hidden from "@material-ui/core/Hidden"; | |||
| import Alert from "components/Alert"; | |||
| import CircularProgress from "components/CircularProgress"; | |||
| import UserOverview from "components/UserOverview/UserOverview"; | |||
There was a problem hiding this comment.
Suggested change
| import UserOverview from "components/UserOverview/UserOverview"; | |
| import UserOverview from "components/UserOverview"; |
darrenvong
reviewed
Jul 31, 2022
| @@ -2,7 +2,7 @@ import { Meta, Story } from "@storybook/react"; | |||
| import { User } from "proto/api_pb"; | |||
| import users from "test/fixtures/users.json"; | |||
|
|
|||
| import { ProfileUserProvider } from "../hooks/useProfileUser"; | |||
| import { ProfileUserProvider } from "../../features/profile/hooks/useProfileUser"; | |||
There was a problem hiding this comment.
We should prefer absolute imports here when it's more than one level of . or .. to ease future changes if needed rather than having to guess how many .. levels to go up.
Comment on lines
+6
to
+10
| import { | ||
| hostingStatusLabels, | ||
| meetupStatusLabels, | ||
| } from "../../features/profile/constants"; | ||
| import { ProfileUserProvider } from "../../features/profile/hooks/useProfileUser"; |
There was a problem hiding this comment.
Same comment on absolute import as before
Comment on lines
+17
to
+21
| import { useProfileUser } from "../../features/profile/hooks/useProfileUser"; | ||
| import { | ||
| ReferencesLastActiveLabels, | ||
| ResponseRateLabel, | ||
| } from "../../features/profile/view/userLabels"; |
There was a problem hiding this comment.
Same comment on absolute import as before
|
@iamseye How are you getting on with this? Will you have time to wrap this up? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Couchers-org/couchers#4139
userOverviewcomponents to the component folderuserOverviewNoted, left some questions for design. still looks very different from the design: https://www.figma.com/file/z1aQUklCQewLsEFUo2HsLz/Desktop-Mockups?node-id=9722%3A63431
Web frontend checklist
make formatmake lint