-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backend/bugfix/4098 expired pending request showing new #5215
Open
Krishnag09
wants to merge
8
commits into
develop
Choose a base branch
from
backend/bugfix/4098-expired-pending-request-showing-new
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Backend/bugfix/4098 expired pending request showing new #5215
Krishnag09
wants to merge
8
commits into
develop
from
backend/bugfix/4098-expired-pending-request-showing-new
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This reverts commit 2d9ddaf.
Which issue is this addressing? I think it's better not to keep expiration state in the database explicitly. Then we'd need to keep updating it and have some background job to do it. It should be a computed field: if it's now past the end of the request, then it's expired. |
…nd/bugfix/4098-expired-pending-request-showing-new
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend checklist
ruff check --select I --fix . && ruff check . && ruff format .
inapp/backend
develop
if necessary for linear migration historyWeb frontend checklist
yarn format
yarn lint --fix